is_front_page issue with no pages

[Connorhd]

With no published pages the setting "show_on_front" is removed when the reading settings are changed, this causes show_on_front to always return false.

[sivel]

I think we are trying to patch the wrong thing here. The is_front_page function does the following check:

        // most likely case
        if ( 'posts' == get_option('show_on_front') && is_home() )
                return true;

That logic should catch this scenario. If it isn't then we need to find out what show_on_front is not set as 'posts' here and patch the code responsible for that failure.

[sivel]

When no pages are present add a hidden input field so that the option is not blanked

[sivel]

New patch adds a hidden input field to options-reading.php when no published pages are present. This saves options.php from blanking show_on_front when saving.

Viper007Bond and I discussed fixing this for backwards compat and without the user going to options-reading.php and clicking "Save Changes" the option will still remain blank. I am open to suggestions, but really feel that fixing it in the is_front_page logic is the wrong place.

[nacin]

(In [14362]) When no pages are present add a hidden input field so that the show_on_front option is not blanked. Fixes is_front_page return value in an edge case. props sivel, fixes #12737, fixes #9105.