WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12746 closed defect (bug) (fixed)

edit-tag-form.php filters AFTER submit button?

Reported by: jfarthing84 Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: UI Keywords: 2nd-opinion has-patch
Focuses: Cc:

Description

If you were to hook into the edit tag (taxonomy) form in edit-tag-form.php, anything you add outside of the table (using '[taxonomy]_edit_form') will show up after the submit button, which just isn't right. Shouldn't the submit button be last?

Attachments (2)

12746.diff (874 bytes) - added by jfarthing84 4 years ago.
Do '[taxonomy]_edit_form' hooks after submit button.
edit-tags.diff (394 bytes) - added by jfarthing84 4 years ago.
Display "Edit [Taxonomy]" instead of "Edit Tag" in browser title.

Download all attachments as: .zip

Change History (7)

jfarthing844 years ago

Do '[taxonomy]_edit_form' hooks after submit button.

comment:1 jfarthing844 years ago

  • Keywords dev-feedback has-patch added

While on the subject, when editing a term, it still shows 'Edit Tag' in the browser window, regardless of the taxonomy.

jfarthing844 years ago

Display "Edit [Taxonomy]" instead of "Edit Tag" in browser title.

comment:2 dd324 years ago

  • Owner set to dd32
  • Status changed from new to accepted

Sounds reasonable to me, Have to check where those filters were on pre 3.0 to make sure its not breaking some thing..

comment:3 dd324 years ago

(In [13876]) Display "Edit $taxonomy" on edit-tags.php Edit screen. Props jfarthing84. See #12746

comment:4 dd324 years ago

  • Keywords 2nd-opinion added; dev-feedback removed

Have to check where those filters were on pre 3.0 to make sure its not breaking some thing..

It was the same in 2.9.

The hooks mentioned here shouldnt be used to add extra fields, however, Adding it before the submit button does seem a far better location than we currently are using.

comment:5 dd324 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14398]) Move edit_<tax>_form and <tax>_edit_form to above submit button. Fixes #12746

Note: See TracTickets for help on using tickets.