A few query bugs...

[jfarthing84]

I found a few bugs in query.php relating to attachments and taxonomies.

If you specify 'taxonomy' and 'term' in a query (therefore causing the $post_status_join to be true) and also a 'post_mime_type', it breaks the query because the post mime type is added like "post_mime_type =" rather than "wp_posts.post_mime_type=", making the post_mime_type column ambiguous.

Also, very related is the fact that querying a taxonomy automatically sets the post status to 'publish' regardless of any post status a specify. Why? What if I wanted to query all the drafts of a taxonomy or all of my own custom status?

[scribu]

Related: #12744

[scribu]

I think it's pretty clear that both issues should be addressed, but it can't be considered a blocker.

[jfarthing84]

Fix custom taxonomy status and attachment queries.

[stephdau]

Patch refresh and patch created from site root, not from within wp-includes

[nacin]

(In [14478]) Prevent ambiguous table aliases in wp_post_mime_type_where. props stephdau, jfarthing84, fixes #12750.

[nacin]

The other bug is mentioned in a slew of other tickets.

[nacin]

Follow-up to [14478] — #20193.