WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12771 closed defect (bug) (fixed)

Comments do not work after commit 9175

Reported by: pgquiles Owned by: iandstewart
Milestone: WordPress.org Priority: normal
Severity: major Version:
Component: Themes Keywords:
Focuses: Cc:

Description

Commit 9175 implemented threaded comments and moved this line:

<input type="hidden" name="comment_post_ID" value="<?php echo $id; ?>" />

to a new generic function "comment_id_fields()" as per issue 7635:

http://core.trac.wordpress.org/changeset/9175

http://core.trac.wordpress.org/ticket/7635

Problem is it broke the default theme for me. I have been suffering this issue for months now but I never found the fix until yesterday:

http://wordpress.org/support/topic/38683
(see comment by westi)

I reversed 9175 locally and now the default theme works again in Wordpress 2.9.7 (and I guess it would fix the issue in many older versions too)

I don't know whether this issue needs fixing, or what kind of fix, now that classic and default themes have been removed, thought:

http://core.trac.wordpress.org/changeset/13879

Change History (7)

comment:1 scribu4 years ago

  • Milestone Unassigned deleted
  • Resolution set to invalid
  • Status changed from new to closed

This ticket missed the train.

I guess you should take it up with whoever maintains the default theme now.

comment:2 nacin4 years ago

  • Component changed from Comments to WordPress.org
  • Milestone set to WordPress.org site
  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:3 nacin4 years ago

  • Owner set to iandstewart
  • Status changed from reopened to assigned

comment:4 nacin4 years ago

  • Component changed from WordPress.org to Themes

comment:5 iandstewart4 years ago

@pgquiles This is working for me in 3.0 RC3. Is your comment-template.php up to date?

comment:6 mrmist4 years ago

Is this still an issue?

comment:7 johnbillion4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing as per iandstewart's comment. Re-open if it's still an issue.

Note: See TracTickets for help on using tickets.