Don't fire wp_notify_postauthor() when the author moderated the comment

[nacin]

In wp_notify_postauthor(), there is this bit of code with an inline comment:

// The author moderated a comment on his own post
if ( $comment->user_id == $post->post_author )
    return false;

The comment doesn't match the code. The code actually prevents the e-mail whenever the author *made* a comment on their own post.

That said, the comment should have code for it. If the author moderates a comment on their own post (a comment not written by them, that is), the author should not get a comment notification. Thoughts?

[scribu]

Makes sense.

Also, an admin shouldn't get a comment notification after moderating any comment. (I have a plugin that deals with this: ​Filter Email Notifications).

[nacin]

In some way related to that: #11277 #11210 #11297.

[scribu]

Seems like a notification overhaul would be in order.

[nacin]

Replying to scribu:

Seems like a notification overhaul would be in order.

I'd identify the issue being the site admin email not being tied to a single admin/owner account, particularly for #11210 and #11297. Deciding whether to enforce that would be a big change.

[mrmist]

Don't notify the author when he moderated the comment

[mrmist]

Attached my attempt at solving the original ticket's issue. (Assumes the moderator is the current user)

[scribu]

[16208]

[nacin]

Didn't notice an issue with the logic in the patch until now:

( $user->user_id == $moderating_uid )

but:

$moderating_uid = (int) $user->id;

This should be:

$moderating_uid = $moderating_user->id;

Or even better, just get_current_user_id(), and we can clean this up a little in terms of standards.

[nacin]

New patch. Can someone double-check my logic?

I've renamed a local variable or two, which makes it really easy to follow now.

[mrmist]

New patch seems sensible to me. Not sure how it relates to [16223]

[ryan]

Looks good.

[nacin]

(In [16304]) Don't notify the author when they posted or moderated the comment. fixes #12774.