Custom post types cannot upload media or set thumbnails unless "editor" is enabled

[markjaquith]

Expected: setting "thumbnail" for custom post type allows for setting of thumbnail:

Observed: Unless "editor" is set, thumbnails won't work.

More:

In order to upload media or set thumbnails, the "editor" post type capability needs to be set. This isn't always desirable.

We should show the buttons if "thumbnail" is set but "editor" is not. Perhaps in its own "Media Upload" meta box.

[scribu]

Related: #12590

[scribu]

We should show the buttons if "thumbnail" is set but "editor" is not. Perhaps in its own "Media Upload" meta box.

I disagree. If you want to upload media, go to the Media screen.

To fix the thumbnail problem, we should replace jQuery('#add_image').click(); with something less presumptive.

[markjaquith]

To fix the thumbnail problem, we should replace jQuery('#add_image').click(); with something less presumptive.

attachment 12792.diff added

Nicely done! Solves that issues very cleanly.

[markjaquith]

(In [14015]) Make thumbnail work for custom post types even if the editor is not being displayed. props scribu. fixes #12792

[markjaquith]

(In [14030]) TB_iframe fixes for stuff that broke in r14015. props scribu. fixes #12878. see #12792

[scribu]

Restore thickbox title for featured images

[scribu]

When clicking "Set featured image", the thickbox title is blank. This is fixed in 12792.2.diff.

When the editor isn't displayed, we should also remove the "Insert into Post" button.

[scribu]

Conditionally display "Insert into Post" button

[nacin]

(In [14118]) More tweaks for thumbnail support when no editor support for custom post types. see #12792, props scribu.

[nacin]

This seems good for me. Re-open if it not, or open a new ticket.

[dd32]

$_GETpost_id? is not always present, specifically, on the 2nd load of a async upload, only fetch & attachment_id are passed.

[automattor]

(In [14146]) Use the correct field when determining if the parent can support the Post Editor. See #12792