WordPress.org

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#1282 closed enhancement (fixed)

"All Comments" feed does not include post titles

Reported by: skippy Owned by: skippy
Milestone: Priority: normal
Severity: normal Version: 1.5.1.1
Component: Template Keywords: bg|has-patch bg|dev-feedback
Focuses: Cc:

Description

It's a pain to hover over a comment's link in my aggregator to see the permalink in order to determine to which post the comment was applied. The supplied patch includes each posts' title in the <title> element when viewing the "all comments" feed.

Attachments (1)

wp-commentsrss2_patch.txt (367 bytes) - added by skippy 16 years ago.

Download all attachments as: .zip

Change History (9)

#1 @skippy
17 years ago

  • Patch set to No

#2 @skippy
17 years ago

An arguably easier solution would be to fix the_title_rss() to accept a parameter:

function the_title_rss($title = 0) {

$title = get_the_title($title);
$title = apply_filters('the_title', $title);
$title = apply_filters('the_title_rss', $title);
echo $title;

}

Since get_the_title() only uses the global $post object if $title is zero, this should work just fine.

#3 @mdawaffe
16 years ago

The patch is essentially what I do (though I think you'd want an && not an
- either that or rework your parentheses), but your comment above is the better solution.

#4 @skippy
16 years ago

  • Severity changed from minor to enhancement
  • Version changed from 1.5 to 1.5.1.1

/wp-commentsrss2.php:

52c52
<               <title>Comment on <?php the_title_rss($comment->comment_post_ID); ?> by: <?php comment_author_rss() ?></title>
---
>               <title>by: <?php comment_author_rss() ?></title>

wp-includes/feed-functions.php:

12,13c12,13
< function the_title_rss($id = 0) {
<       $title = get_the_title($id);
---
> function the_title_rss() {
>       $title = get_the_title();

#5 @markjaquith
16 years ago

  • Keywords bg|has-patch bg|dev-feedback added

#6 @skippy
16 years ago

  • Milestone set to 1.5.2
  • Owner changed from anonymous to skippy
  • Status changed from new to assigned

#7 @matt
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2781]) Fixes #1282

#8 @(none)
15 years ago

  • Milestone 1.5.2 deleted

Milestone 1.5.2 deleted

Note: See TracTickets for help on using tickets.