WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12846 closed defect (bug) (fixed)

Change references from default theme to WP_FALLBACK_THEME

Reported by: MichaelH Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Template Keywords: has-patch
Focuses: Cc:

Description

Several places still reference the "default" theme folder.

Attachments (1)

12846.diff (1.8 KB) - added by MichaelH 4 years ago.

Download all attachments as: .zip

Change History (5)

MichaelH4 years ago

comment:1 MichaelH4 years ago

Don't know if these two places should be changed, but will reference them:

In wp-admin/themes.php line there is this reference to default but wonder if changing that to WP_FALLBACK_THEME hinders translation:

<div id="message1" class="updated"><p><?php _e('The active theme is broken.  Reverting to the default theme.'); ?></p></div>

and in wp-includes/theme.php not sure what this is for:

if ( ('WordPress Default' == $name || 'WordPress Classic' == $name) &&
   ('default' == $stylesheet || 'classic' == $stylesheet) ) {

comment:2 michaelh4 years ago

  • Keywords has-patch added

comment:3 ryan4 years ago

(In [14080]) Use WP_FALLBACK_THEME instead of default. Props MichaelH. see #12846

comment:4 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14485]) Remove WP_FALLBACK_THEME, use WP_DEFAULT_THEME instead. We now only fall back to the default theme if the theme is broken. Incomplete themes that need to inherit templates will inherit them from wp-includes/theme-compat -- this behavior is deprecated. fixes #12846.

Note: See TracTickets for help on using tickets.