WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#12848 closed enhancement (fixed)

Network instructions need to be more verbose

Reported by: sivel Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

Since the release of WP 3.0 beta 1 we have had a number of people testing the network configuration. The only problem is a number of them seem to be placing the required code in wp-config.php below the line reading:

/* That's all, stop editing! Happy blogging. */

Add a few extra words to the instructions to specify that it should go above.

Attachments (1)

12848.diff (977 bytes) - added by sivel 10 years ago.
Add some additional instructions

Download all attachments as: .zip

Change History (7)

@sivel
10 years ago

Add some additional instructions

#1 @sivel
10 years ago

  • Cc matt@… added
  • Keywords has-patch added

Attached patch adds some additional instructions as to where to place the code required in wp-config.php

#2 @nacin
10 years ago

(In [13999]) More verbose message on how to add MS constants to one's config file. props sivel, see #12848

#3 @nacin
10 years ago

(In [14000]) Prevent half-baked loading of MS that would happen when constants are added into wp-config below the wp-settings include. Now it would error on the redefinition of the MULTISITE constant, instead of vague errors, and prevent any MS from loading. see #12848

#4 @nacin
10 years ago

I've been thinking about [14000] for a while. This will keep the site operational as non-MS, instead of a half-loaded MS admin screen and a fatal error on get_dirsize().

Most people wouldn't see the notice spit out by the redefinition of a constant, but I think "Why am I not getting my network panels?" is better than "Why isn't WordPress working? The Network feature sucks."

I realized I can now improve the is_multisite() logic with:

function is_multisite() {
	if ( defined( 'MULTISITE' )
		return (bool) MULTISITE;

	if ( defined( 'VHOST' ) || defined( 'SUNRISE' ) )
		return true;

	return false;
}

#5 @sivel
10 years ago

Great thinking, I like this.

#6 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

The enhancement is fixed in [13999].

The is_multisite() improvement is done in [14036]. If someone have problems with it, reopen or create a new ticket.

Note: See TracTickets for help on using tickets.