"Preview Changes" does not work for custom content types

[markjaquith]

If you click "Preview Changes" for a custom post type item, you receive the message "Are you sure you want to do this?"

Likely a nonce mismatch issue. Here is the test code to add a custom post type:

                register_post_type(
                        'album', array(
                        'label' => __('Albums'),
                        'singular_label' => __('Album'),
                        'public' => true,
                        'show_ui' => true,
                        '_edit_link' => 'post.php?post=%d',
                        'capability_type' => 'page',
                        'hierarchical' => false,
                        'rewrite' => true,
                        'query_var' => 'album',
                        'supports' => array('title', 'thumbnail')
                ));

[duck_]

case 'preview' in wp-admin/post.php checks for valid 'autosavenonce' (line 268). This is only present in the post editing page if the editor is present (edit-form-advanced.php line 244). This can be tested by adding 'editor' to the supports array, you should find that you can now preview changes. Definitely needs a fix, also noticed this whilst looking into some other bugs (​http://core.trac.wordpress.org/ticket/11082#comment:26)

[duck_]

Move nonce fields out of conditional

[duck_]

Don't see why there would be a reason for the four nonce fields to be inside the check for the post type supporting the editor (please correct me and tell me why if I'm wrong!).

Therfore, also fixes: unable to persist rearranged/hidden meta-boxes on custom post type pages & being unable to edit permalink for custom post types (though I cannot seem to get these permalinks to work anyway :S).

[nacin]

Some nonces can be restricted to a certain feature, but yeah, grouping them in 'editor' can do some damage. For example, we also currently require a post type support of 'title' to show the permalink settings.

[duck_]

Moves samplepermalink nonce into title support conditional. Removes getpermalink nonce as this is no longer used (see r9473 on autosave.js - perhaps get-permalink case in admin-ajax.php can also be removed?). Moves the other nonce fields out of the editor support conditional and up to the other hidden fields.

[dd32]

(In [14148]) Move nonces into better locations, Currently nested within the Editor support, which is not always enabled. Props duck_. Fixes #12867