LiveJournal importer uses GMT date/time as local date/time

[kurtmckee]

The LiveJournal importer takes a comment's date/timestamp, which is in GMT, and inserts it into the database as the comment's local date/timestamp. In my timezone (U.S. Central, DST), a comment posted at 12:00pm local time (5:00pm GMT) will be imported to the database as having been posted at 5:00pm local time (10:00pm GMT).

I've attached a patch that I've successfully tested on Wordpress 2.9.2, and it appears to be easily ported to trunk. One caveat: it appears that there are two timezone settings in the Wordpress database (timezone_string and gmt_offset), but as my database has no value for gmt_offset, I don't know if I need to account for that, nor can I test that.

[kurtmckee]

Adjust LiveJournal comment dates and times from GMT to local time (applies to WP 2.9.2)

[Frumph]

Note about the gmt_offset, my installation didnt have a value in it either, after upgrading from wpmu to 3.0

[kurtmckee]

Has anyone had an opportunity to review the patch? Are there any suggestions that I should incorporate in order to make the code acceptable to commit?

[nacin]

I think we have a function somewhere to do that conversion -- would it be get_date_from_gmt?

[kurtmckee]

Thanks for the quick response and the tip! I'll look for that function (or a similar one), update the patch to work with trunk, and test it as soon as possible.

[kawauso]

Related: #5842

[kawauso]

Patch #12885 and #5842 with get_date_from_gmt()

[kawauso]

Patch with get_date_from_gmt(), but no LiveJournal account to test with here

[chriscct7]

Related (in terms of updating the LJ Importer plugin): #15760

[chriscct7]

Based on #5842 this might be invalid