Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#12887 closed defect (bug) (fixed)

Undefined variable: type in wp-admin/includes/template.php on line 1130

Reported by: caesarsgrunt Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Quick/Bulk Edit Keywords:
Focuses: Cc:


Line 1130 of wp-admin/includes/template.php, in the function inline_edit_row(), reads as follows :

		do_action( $bulk ? 'bulk_edit_custom_box' : 'quick_edit_custom_box', $column_name, $type);

but the variable $type is no defined anywhere.

The phpdoc for the function states that there should be a $type attribute :

 * @param string $type 'post' or 'page'

but the only parameter is actually $screen.

The result is that with WP_DEBUG set I get the following error for every custom column :

Notice: Undefined variable: type in /Users/caesar/Sites/wordpress/wp-admin/includes/template.php  on line 1130

Running latest nightly as of 7th April @ 05:00 GMT.

Change History (2)

#1 @nacin
6 years ago

See [12728]. Should have been changed over to the current screen object.

#2 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14026]) Use correct var in inline_edit_row(). fixes #12887.

Note: See TracTickets for help on using tickets.