WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#1290 closed defect (bug) (fixed)

Smart quotes in <pre> done by mistake

Reported by: Thiemo Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.1
Component: General Keywords: dev-feedback
Focuses: Cc:

Description

Inside of [pre], [code] and some other tags sometimes the "smart replacements" of quotes and so on are done by mistake. Try:

[pre]An "example" [strong]andstrong another "example".pre

The second quotes are replaced, the first are not. I added a fix for this.

Attachments (2)

functions-formatting.php.diff (707 bytes) - added by Thiemo 9 years ago.
functions-formatting.php.2.diff (734 bytes) - added by Thiemo 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Thiemo9 years ago

  • Patch set to No

comment:2 Thiemo9 years ago

The first patch does not work properly. I added a new one.

comment:3 Justinsomnia8 years ago

  • Resolution set to duplicate
  • Status changed from new to closed
  • Version changed from 1.5 to 2.0.1

More information and a patch available on #2059 (duplicate)

comment:4 Justinsomnia8 years ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

comment:5 rob1n7 years ago

  • Keywords dev-feedback added
  • Milestone set to 2.2
  • Version changed from 2.0.1 to 2.1

Would keeping smart quotes out of PRE's and CODE's be feasible? Sounds like a good idea IMO. I've heard lots of stories of poeple's code being messed up due to copy+pasting curly quotes.

comment:6 JeremyVisser7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This already appears to be fixed. Using WP 2.1.1-alpha.

comment:7 foolswisdom7 years ago

  • Milestone 2.2 deleted
Note: See TracTickets for help on using tickets.