WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12919 closed defect (bug) (fixed)

Show details link on plugin upgrade doesn't change when expanded

Reported by: caesarsgrunt Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

When bulk upgrading plugins, for each one there is a notice which reads "{{plugin}} updated successfully. See Details."

Clicking See Details shows each step of the upgrade. But the text "See Details" remains.

It should change to "Hide Details" instead.

Latest nightly as of 8th April.

Attachments (2)

12919.patch (1.6 KB) - added by ocean90 4 years ago.
12919.2.patch (3.4 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 dd324 years ago

Should probably be replaced with "Show Details" (and "Hide Details")

ocean904 years ago

comment:2 ocean904 years ago

  • Keywords has-patch added; needs-patch removed

In 12919.patch I replaced it with Show Details and Hide Details.

comment:3 nacin4 years ago

We probably need some hide-if-no-js support there.

I haven't had the chance to look through the UI in #11232. Probably this weekend.

comment:4 ocean904 years ago

nacin, good point, I have add the no-js support to the iframe and add the hide-if-no-js classes in 12919.1.patch.

ocean904 years ago

comment:5 dd324 years ago

the JS classes will not operate properly in this case, The Javascript runs on document load, the document doesnt load until all upgrades are complete, which leads to a mass jump at the end to close the boxes...

Or at least, thats how it worked when i wrote that skin.

comment:6 dd324 years ago

Actually.. that comment was entirely wrong on many levels. However, that patch wont work as expected.

The reasoning is, that the no-js Javascript is not included on iframe pages.

comment:7 dd324 years ago

Its too late. I didnt notice the 2nd half of your patch. Ignore me...

comment:8 dd324 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14123]) Toggle between "Show Details" and "Hide Details" on GUU; Add no-js CSS class support to generic iframe header. Props ocean90. Fixes #12919

Note: See TracTickets for help on using tickets.