WordPress.org

Make WordPress Core

Opened 10 years ago

Last modified 4 months ago

#12960 new enhancement

Number of posts on the Users page should include drafts and pending review

Reported by: archon810 Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9.2
Component: Users Keywords: has-patch needs-testing
Focuses: Cc:

Description

The numbers of posts on the Users page currently only include published posts, which I think is not good enough. For example, I have a contributor who has only written a few drafts and submitted a few articles for review.

If I decide to delete him and base my decision on what I see on the Users page, I would probably just go with the "Delete the user and all his posts" option, which would delete more than I would expect.

Attachments (4)

12960.diff (486 bytes) - added by wojtek.szkutnik 10 years ago.
12960.1.diff (1.2 KB) - added by Nikschavan 4 years ago.
12960.2.diff (665 bytes) - added by Nikschavan 4 years ago.
12960.3.diff (5.5 KB) - added by donmhico 4 months ago.

Download all attachments as: .zip

Change History (14)

#1 @archon810
10 years ago

  • Cc admin@… added

#2 @wojtek.szkutnik
10 years ago

  • Keywords gsoc has-patch needs-testing added

Indeed, scheduled, pending and draft posts should be counted as well

#3 @wojtek.szkutnik
10 years ago

  • Cc wojtek.szkutnik@… added

#4 @nacin
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @chriscct7
6 years ago

  • Keywords needs-testing removed

Patch is still good

#7 @chriscct7
5 years ago

  • Keywords needs-refresh added; gsoc removed

@Nikschavan
4 years ago

@Nikschavan
4 years ago

#8 @Nikschavan
4 years ago

  • Keywords needs-testing added; needs-refresh removed

Refreshed the patch with current trunk in 12960.2.diff

This needs to be tested as the function get_posts_by_author_sql is also used in WP_User_Query->parse_orderby()

#9 @archon810
6 months ago

This ticket is now 10 years old. Ping?

@donmhico
4 months ago

#10 @donmhico
4 months ago

Thanks for the ticket @archon810. Yeah it's 10 years old now! Hopefully this could gain traction soon.

While @Nikschavan patch works (thanks for the patch!), I don't think directly changing the SQL inside get_posts_by_author_sql() is the best approach since it could lead to unwanted changes to any plugins / themes that uses the function.

In my latest patch, 12960.3.diff, I introduced a new parameter $include_unpublished which if set to true would add the SQL that will include pending, future, and draft posts.

Note: See TracTickets for help on using tickets.