WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12963 closed enhancement (fixed)

Do not hardcode TABINDEX into comment_form()

Reported by: demetris Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Accessibility Keywords: 2nd-opinion dev-feedback has-patch
Focuses: Cc:

Description

Have we thought whether we have a good reason for adding tabindex to the elements of the new comment_form()?

If we are doing it for accessibility, the accessibility folks seem to recommend against it. E.g.:

http://www.webaim.org/techniques/keyboard/tabindex.php

Are there other considerations in addition to accessibility?

We could take the safe road of making tabindex filterable. However, since that would take work, if it was up to me I would be itching to remove tabindex completely from comment_form().

Thoughts?

PS. Two articles I came across while searching to see if the issue had been discussed before within WordPress:

http://www.lukerodgers.ca/2009/03/wordpress-comment-form-tabindex-no-no/

http://www.456bereastreet.com/archive/200712/overdoing_accessibility/

Attachments (1)

remove_tabindex_comment_form.diff (3.6 KB) - added by ptahdunbar 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 ptahdunbar4 years ago

  • Keywords has-patch added

comment:2 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14114]) Remove tabindex from comment_form(). fixes #12963

Note: See TracTickets for help on using tickets.