WP_Http_Fopen not available for load_image_to_edit()

[ryan]

Fatal error: Class 'WP_Http_Fopen' not found in /.../wp-admin/includes/image-edit.php on line 206

Due to the way class-http.php is now demand loaded.

[ryan]

[14079]

[ryan]

Leaving open pending discussion of whether to merge class-http.php back into http.php.

[nacin]

Always including it avoids the extra open() syscall, so I'm all for that.

Not sure we need to combine them again. Maybe we can better document the API in http.php and leave them separate. I do like the split, as we separated more than a thousand lines of internals from the functions we want developers to use.

[nacin]

(In [14081]) Unbreak setup-config.php. see #12990

[dd32]

Whats the argument here for fixing the parts of the code that rely on the class existing, verses always including it?

We might as well just merge it back together if we're going to always include it.. The reason to split it was partially to prevent having to include a set of code which we weren't going to otherwise use..

[nacin]

Always including it avoids the extra open() syscall for the times we do need it. I don't really have a problem with keeping the files separate, but if there's a desire to re-merge them, we could.

[dd32]

Always including it avoids the extra open() syscall for the times we do need it

Which is required rarely compared to when we do. an extra syscall for when needed compared to always opening the file and parsing the contents is going to be faster overall.

[nacin]

Ryan admittedly chose the easy route just to get everything back online. I don't have any preference in how we proceed.

[dd32]

The Cookie class might also be needed for direct access before making a request, so having them both included is probably best..

[sivel]

Ok, consensus is to leave the files split and include them both, which is the current way we are doing it. Closing as fixed.