![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 16 years ago
Closed 16 years ago
#13009 closed defect (bug) (fixed)
When inheriting twentyten's comments.php, theme breaks.
| Reported by: | ptahdunbar | Owned by: | westi |
|---|---|---|---|
| Priority: | high | Milestone: | 3.0 |
| Component: | Template | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
If a theme has no comments.php file, WP falls back to twentyten's comments.php file.
This breaks the theme because twentyten requires twentyten_comment() (defined in functions.php) which isn't loaded, causing a fatal error.
Patch moves twentyten_comment() from functions.php into the top of comments.php. Fixes fatal error.
Attachments (1)
Change History (5)
#2
@
16 years ago
I wonder if it would not be better to do away with the fallback and do the following on upgrade:
1) Check for themes relying on the fallback and copy header/footer/comments over to the theme from default
2) Remove the fallback code
3) Publicise that these files are required in a theme
We could also consider a special 'fallback' theme which just contains the files we fallback too and nothing else so can't be a parent theme
#3
@
16 years ago
- Owner set to
- Status new → accepted
Working on a solution to this as well as #12425
We're going to have this same issue with header.php.