Opened 15 years ago
Closed 14 years ago
#13034 closed enhancement (fixed)
Add class-wp-importer.php to wp-admin/includes directory
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.0 | Priority: | normal |
| Severity: | normal | Version: | 3.0 |
| Component: | Import | Keywords: | has-patch early |
| Focuses: | Cc: |
Description (last modified by )
Add the WP_Importer base class to wp-admin/includes.
Importers can extend this class for shared functionality.
Future importer plugins will not have a dependency on this class as a separate plugin.
This class is used on WordPress.com and tested extensively.
Attachments (1)
Change History (11)
#2
@
15 years ago
- Description modified (diff)
- Milestone changed from Future Release to 3.1
- Owner set to ryan
- Status changed from new to assigned
- Version set to 3.0
#3
@
15 years ago
- Keywords has-patch added
Fine by me. Was just getting it out of the unasssigned no-man's land.
#4
@
15 years ago
Random thoughts: min_whitespace and stop_the_insanity are both global scope. Should they be? If so, they should get better names and should probably be moved out of admin-only includes. I'd think they can be class methods however. Also, min_whitespace does not appear to be UTF-8 friendly, versus [\r\n\t ].
#7
in reply to:
↑ 6
@
14 years ago
- Keywords early added
Replying to briancolinger:
File updated with @nacin's suggestions.
Thanks! Though now, get_args() seems too generic a name. get_cli_args() perhaps?
Discussed with Ryan, setting to 3.1 and assigning to him as he can most easily call on his Automattic colleagues.