WP_Query gets the user ID for author archives twice

[simonwheatley]

Currently WP_Query->get_posts does this:

			$q['author'] = $wpdb->get_var("SELECT ID FROM $wpdb->users WHERE user_nicename='".$q['author_name']."'");
			$q['author'] = get_user_by('slug', $q['author_name']);

Which potentially hits the DB twice for the same info. Looks like an old bit of functionality got left in when the get_user_by call was added. Would be better if it went like this:

			$q['author'] = get_user_by('slug', $q['author_name']);

[simonwheatley]

A diff to stop WP_Query hitting the DB twice for the author ID on author archives

[simonwheatley]

Ugh. Wrong format for the codeblocks in the description, sorry... see the diff. :/

[dd32]

fixed the code in the desc.

[scribu]

[14160]

[dd32]

Thanks scribu