Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13053 closed enhancement (fixed)

Remove searchform.php from Twenty Ten

Reported by: demetris Owned by: iammattthomas
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch
Focuses: Cc:


In the interests of simplicity and of taking advantage of—rather than duplicating—useful functionality provided by WP core, I propose to completely remove searchform.php from Twenty Ten.

The differences of Twenty Ten’s searchform.php from the output of get_search_form are two:

  1. Twenty Ten omits the role attribute. There is no reason to do that anymore, since ARIA landmark roles are valid in HTML5 and are recognized as such by the W3 validator.
  1. Twenty Ten adds the string “Search” before the search box. That string is redundant.

I don’t know how to make a patch for the propesed change. Simply delete the file! :-)

Change History (3)

comment:1 @nacin5 years ago

  • Owner set to iammattthomas
  • Status changed from new to assigned

comment:2 @zeo5 years ago

+1 delete

comment:3 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14331]) Remove Twenty Ten's searchform.php and use the core get_search_form() markup. fixes #13053

Note: See TracTickets for help on using tickets.