Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13062 closed defect (bug) (fixed)

r14123 breaks TB window on plugin/theme installers

Reported by: demetris Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords: has-patch
Focuses: Cc:


I’m seeing this on two different setups, with both browsers I tried, Firefox and Opera:

The ThickBox has now an horizontal scrollbar, and you need to scroll to to the right to see all content, in order, e.g., to click the Install link.

Guilty revision: r14123

Attachments (1)

13062.patch (865 bytes) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (5)

@ocean905 years ago

comment:1 @ocean905 years ago

  • Component changed from JavaScript to UI
  • Keywords has-patch added; needs-patch removed

Sry, my mistake. Class wp-admin has a min-width of 785px. I also have removed the folded class because we didn't need it in the iframe.

comment:2 @azaozz5 years ago

I think the admin_body_class filter shouldn't be there too. This is not the "admin body". If we need to give access to plugins to add CSS classes there perhaps can add guu-iframe-body-class or similar, although don't think that's needed.

comment:3 @dd325 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14210]) Remove Horizontal scrollbars on Thickbox iframes. Props ocean90. Fixes #13062

comment:4 @dd325 years ago

I removed the admin_body_class filter as well. Didnt see a point in adding anything in its place.

Note: See TracTickets for help on using tickets.