Make WordPress Core

Opened 5 years ago

Last modified 7 months ago

#13071 reopened defect (bug)

Update bubble appears only at the second load

Reported by: ocean90 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Upgrade/Install Keywords: needs-patch
Focuses: administration Cc:


Change the version of a plugin and go directly to wp-admin/update-core.php page.
You will see the plugin update in the list but the bubbles on the menu appears only after a reload.

Attachments (1)

update.diff (886 bytes) - added by bswatson 11 months ago.

Download all attachments as: .zip

Change History (21)

comment:1 @ocean905 years ago

IRC log:

[18 Apr 10 18:25] * nacin * yeah, they're a page load behind.
[18 Apr 10 18:36] * nacin * ocean90: If we switch two giant code blocks in plugins.php, that one pageload delay goes away. I don't want to break anything else though at this point in the cycle
[18 Apr 10 18:37] * nacin * more or less, moving the admin-header.php call (and related code = 70 lines) down below the block that collects all the plugin information (= 100 lines)
[18 Apr 10 18:39] * ocean90 * nacin: so should i create a ticket at first?
[18 Apr 10 18:39] * nacin * If you want. set for 3.1
[18 Apr 10 18:39] * ocean90 * ok
[18 Apr 10 18:40] * nacin * It's low priority, rather minor, but easy to fix. just need to review 200 lines of code to make sure nothing would break.

comment:2 @nacin5 years ago

Related to this, if you run an upgrade, at the end of the upgrade, some JS should run that reduces the bubble count by 1 (or more if bulk), or clear the bubble all together if that's the case.

Both the Dashboard > Updates bubble and the Plugins bubble.

comment:3 @nacin5 years ago

  • Milestone changed from Awaiting Triage to Future Release

comment:4 @Viper007Bond5 years ago

Same thing happens if you directly visit /wp-admin/plugins.php?plugin_status=upgrade when there's an update available. The yellow bar won't be there and you'll need to refresh before you can update.

comment:5 @ocean904 years ago

  • Keywords needs-patch added
  • Priority changed from low to normal

comment:6 @dd324 years ago

Similar (with a patch): #10884

In this case, any update checks hooked to a page/run on a page, need to be hooked before admin menu generation (which the load-$pagenow hook doesnt).

comment:7 @chriscct711 months ago

  • Keywords reporter-feedback added

Can you still reproduce this?

comment:8 @ocean9011 months ago

  • Keywords reporter-feedback removed


comment:9 @chriscct711 months ago

  • Focuses administration added

Okay, will mark as admin focus. The IRC chat makes it seem its just a matter of moving the plugin update code down. Maybe this could be done in 4.1

comment:10 @chriscct711 months ago

  • Keywords good-first-bug added

@bswatson11 months ago

comment:11 @bswatson11 months ago

Patch added, but I wasn't able to shift around lines of code as it's changed significantly since the IRC chat occurred.

comment:12 @bswatson11 months ago

  • Keywords has-patch added; needs-patch removed

comment:13 @johnbillion10 months ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 4.1

comment:14 @dd3210 months ago

  • Owner dd32 deleted
  • Status changed from new to assigned

comment:15 @omarreiss10 months ago

Tested and it works!

comment:16 @Yahire Furniture9 months ago

Yes this is working for me as well

comment:17 @ocean909 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

[30696] missed the ticket.

comment:18 @johnbillion7 months ago

In 31390:

Revert [30696] pending further investigation.

See #31011, #13071

comment:19 @SergeyBiryukov7 months ago

  • Keywords needs-patch added; good-first-bug has-patch needs-testing removed
  • Milestone changed from 4.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:20 @dd327 months ago

In 31394:

Revert [30696] pending further investigation.

Props johnbillion.
Merges [31390] to the 4.1 branch.
See #13071. Fixes #31011.

Note: See TracTickets for help on using tickets.