Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#13094 closed defect (bug) (fixed)

Super admins should be able to view spam, archived, deleted, etc. blogs.

Reported by: ryan Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Multisite Keywords:
Focuses: Cc:


ms_site_check() should allow super admins to view blogs marked as spammed, deleted, archived, etc. Adding an is_super_admin() check to ms_site_check() would require moving ms_site_check() lower in wp-settings.php until after init is fired. This would also allow adding actions/filters to ms_site_check(). The cost is that all of WP would be loaded before dying for these blogs.

Change History (7)

#1 @nacin
10 years ago

The cost is that all of WP would be loaded before dying for these blogs.

I don't see that as much of an issue. It's not harming the performance of anything but the speed of a die message.

#2 @donncha
10 years ago

We definitely need to do this. It means that inactive blogs will load more of WP before dying but it's worth it for the convenience of administrators.

The only issue with performance is when a blog is being DOSed but it'll be fast enough.

#3 @ryan
10 years ago

(In [14198]) Move ms_site_check() to after init and allow super admins to view blocked sites. see #13094

#4 @ryan
10 years ago

There's my take. Tweak as y'all see fit.

#5 @nacin
10 years ago

I think it would need to return true instead of null if short-circuited, otherwise WP would try to include(null) and die.

#6 @ryan
10 years ago

Indeed. I have this fixed locally after running into it. Will commit after some more testing.

#7 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14199]) Return true. fixes #13094

Note: See TracTickets for help on using tickets.