Super admins should be able to view spam, archived, deleted, etc. blogs.

[ryan]

ms_site_check() should allow super admins to view blogs marked as spammed, deleted, archived, etc. Adding an is_super_admin() check to ms_site_check() would require moving ms_site_check() lower in wp-settings.php until after init is fired. This would also allow adding actions/filters to ms_site_check(). The cost is that all of WP would be loaded before dying for these blogs.

[nacin]

The cost is that all of WP would be loaded before dying for these blogs.

I don't see that as much of an issue. It's not harming the performance of anything but the speed of a die message.

[donncha]

We definitely need to do this. It means that inactive blogs will load more of WP before dying but it's worth it for the convenience of administrators.

The only issue with performance is when a blog is being DOSed but it'll be fast enough.

[ryan]

(In [14198]) Move ms_site_check() to after init and allow super admins to view blocked sites. see #13094

[ryan]

There's my take. Tweak as y'all see fit.

[nacin]

I think it would need to return true instead of null if short-circuited, otherwise WP would try to include(null) and die.

[ryan]

Indeed. I have this fixed locally after running into it. Will commit after some more testing.

[ryan]

(In [14199]) Return true. fixes #13094