WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13106 closed defect (bug) (fixed)

index.php/ PATHINFO forced when mod_rewrite/iis7 permalinks not available

Reported by: bloggus Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: critical Version: 3.0
Component: Permalinks Keywords: reporter-feedback
Focuses: multisite Cc:

Description

(Created by dd32: Originally reported in #13104)
Hi,

I have been using WP and WPMU with IIS6 and compatibility with mod_rewrite for years. No problem.

Also have been testing out laterst beta1 and today I decided to make a clean install of nightly build of the code.

This are the issues I discovered, divided in three section:

  1. - Single Site

After installing I realized that in the permalinks section I'm forced to use /index.php whick is hardcoded. dd32 explained in the list that this is because I'm not runing IIS7 or Apache. I had to add a filter to remove it. I think most of all this is wrong to force index.php on anybody and this should be removed. I would have to add the filter in all themes for example and there are stil many using IIS6 with some mod_rewrite compatible software.

Change History (20)

comment:1 dd324 years ago

Issues 2&3 are still in #13104

Comment from nacin on pathinfo links:

I agree we probably should adjust index.php handling, but note that MU never handled PATHINFO links properly it seems.

This is where it was changed (by me)

[14051] Check the appropriate radio option on the Permalinks page for the Root blog; Display index.php prefixes properly for the root Multisite Blog. Fixes #12952

comment:2 dd324 years ago

After looking into an alternative implementation of this, I've also noticed that the Permalink selection page does not operate without javascript.

comment:3 dd324 years ago

  • Owner changed from ryan to dd32
  • Status changed from new to accepted

comment:4 dd324 years ago

I've got a patch coming up this week that implements no-js support, uses jQuery, restores the ability to remove the index.php/ prefix, AND works with Multisite still..

comment:5 dd324 years ago

I've got a patch coming up this week that implements no-js support, uses jQuery, restores the ability to remove the index.php/ prefix, AND works with Multisite still..

Will post this during the WCSF Code sprint next week, Flying out pretty soon and dont have time to finalise the code.

comment:6 bloggus4 years ago

Do you think this commit will make into final 3.0?

comment:7 wpmuguru4 years ago

  • Severity changed from normal to blocker

In MU the /index.php was added to the textbox(es) so the user could remove it if they know they are using an alternate web server. Many MU installs use Nginx for performance. This is a significant issue for those installs.

comment:8 anointed4 years ago

I am currently solving the problem by using a plugin with the following code in it:

add_filter('got_rewrite', '__return_true');

This solves the problem, although I am sure there is a better way to fix the issue

comment:9 nacin4 years ago

[14553] revert non-rewrite permalink settings to be compatible with 2.9, see #13106

comment:10 wpmuguru4 years ago

  • Severity changed from blocker to normal

taking the blocker off because the main issue is fixed.

comment:11 follow-up: dd324 years ago

Cheers nacin, I was just coming to ask someone to revert it for me.

Someone should note however, That index.php permalinks will now be broken for the main blog on MU.

comment:12 nacin4 years ago

  • Severity changed from normal to critical

Actually, it was wpmuguru, but the ticket wasn't referenced right in the commit so the hook never fired. I would have done it anyway, of course :-)

So, we still need to fix pathinfo links on the main blog still. While these have never worked in MU (apparently), I'm going to bump the severity again as that's quite crippling.

comment:13 in reply to: ↑ 11 wpmuguru4 years ago

Replying to dd32:

Cheers nacin, I was just coming to ask someone to revert it for me.

Someone should note however, That index.php permalinks will now be broken for the main blog on MU.

This behaves identically to MU 2.9.X. I wonder if with the index.php permalink base whether the /blog is necessary? Probably not, since the /blog was added to prevent collisions with other blogs.

comment:14 wpmuguru4 years ago

  • Keywords multisite added

comment:15 ocean904 years ago

See also #13303

comment:16 nacin4 years ago

Related: [14732]

comment:17 wpmuguru4 years ago

(In [14733]) don't use both /blog & /index.php on main site permalinks, see #13106

comment:18 wpmuguru4 years ago

  • Keywords reporter-feedback added

Can some folks with IIS test that and let us know if that fixes the issue?

comment:19 bloggus4 years ago

  • Cc bloggus removed

I have updated to latest nightly build and updated the options-permalink.php manually, updated the permalinks settings.

Running: IIS6, PHP 5.2x, MySQL, subdomain installation of WP (MS)

So far I see that the issues I have reported are gone. index.php is not forced on the links anymore.

My server with IIS7 is not up at the moment, but it shouldn't be a problem if it works on IIS6.

Thanks.

comment:20 ryan4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.