Failure to load popular tags results in PHP errors in plugin-install.php

[solarissmoke]

Steps to reproduce:

1. Block server access to Wordpress servers (simulating what happens when plugins_api() fails to connect to them)

2. Visit plugins install page (wp-admin/plugin-install.php)

Result:

Undefined index: name in \wplatest\wp-admin\includes\plugin-install.php on line 147 
Undefined index: name in \wplatest\wp-admin\includes\plugin-install.php on line 149
etc etc..

I think the problem is on line 67 of plugin-install.php. If an error occurs, install_popular tags is returning a WP_Error object. But the calling function is expecting an array of tags, and doesn't check that the array is valid before attempting to walk it.

[solarissmoke]

I should add that this also requires the wporg_popular_tags option to be stale, otherwise a web query will not take place.

[solarissmoke]

Return false instead of WP_Error object when plugins_api fails

[dd32]

wordpress: dd32 * r14228 /trunk/wp-admin/includes/plugin-install.php: Handle HTTP errors on popular tags requests, Handle HTTP Errors on listing loading slightly different no-js compatible. Fixes #13107