Opened 16 years ago
Closed 16 years ago
#13110 closed defect (bug) (fixed)
Look at new revision doesn't work on custom post type
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 3.0 | Priority: | high |
| Severity: | normal | Version: | 3.0 |
| Component: | Posts, Post Types | Keywords: | has-patch needs-testing |
| Focuses: | Cc: |
Description
When there is newer version of of an custom post type because of autosave, the link doesn't work.
I looked at wp-admin/revision.php and found out that the problem is the check at rule 130:
elseif ( !post_type_supports($post->post_type, 'revisions') )
Attachments (1)
Change History (12)
#3
@
16 years ago
- Keywords needs-patch added; need-fix removed
We have specific keywords in Trac: http://codex.wordpress.org/Reporting_Bugs#Trac_Keywords
#4
@
16 years ago
- Keywords dev-feedback added
I'm not sure what the outcome should be here -
I think we should 'autosave' even if revisions are disabled for that custom post type.
#6
@
16 years ago
I think if revision isn't used, autosave should work different. Now you got the same message if you would used it but the link is broken.
If it isn't used by the content type, the revision shouldn't be stored but I can see there should be a newer version when there is one.
Because if it should work the same the option better can removed. The way it works now is confusing.
#7
@
16 years ago
- Keywords dev-feedback removed
- Priority changed from low to high
I don't see why 'revisions' should disable autosaving. We still enable autosaves when revisions are disabled, and it should be no different. (Relevant code there is ! WP_POST_REVISIONS && !wp_is_post_autosave( $revision ).
Needs patch. We need to allow revision display for autosaves even when ! post_type_supports('revisions').
I didn't had revisions in my supports:
'supports' => array('title', 'editor', 'author', 'revisions')
So there need an change here.
Not autosave my post or no warning when there is one.