WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13113 closed enhancement (worksforme)

Allow code inside the containers but before and after the menus.

Reported by: thee17 Owned by: ryan
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

Many themes have a clear div before the end container. This allows most existing themes to be able to convert their menus to the new menu system by changing little code, making it easire for themers to have more control.

Attachments (1)

menubeforeafter patch.diff (2.0 KB) - added by thee17 5 years ago.
Addition of menu_before and menu_after parameters.

Download all attachments as: .zip

Change History (3)

@thee175 years ago

Addition of menu_before and menu_after parameters.

comment:1 @nacin5 years ago

I would rather offer that a container should not be used in those situations, and thus the theme can do whatever they want. I don't think we should keep adding so many arguments. It gets to the point where supporting a container div, and customizations thereof, makes less sense than simply doing the container div yourself.

We're going to be committing a patch in the next day or so that will change a few thousand lines of menu code. I am waiting for that to dry up some additional code and simplify the menu HTML creation. Let's hold off here until that gets in so we can see what we're looking that.

comment:2 @thee175 years ago

  • Milestone 3.0 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I did not realize till todyy, if you add a container=>none where it is not a valid tag it removes the container all together.

Note: See TracTickets for help on using tickets.