WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#13114 closed defect (bug) (fixed)

Deprecated functions in Akismet

Reported by: johnbillion Owned by: matt
Milestone: WordPress.org Priority: low
Severity: minor Version:
Component: Plugins Keywords: deprecated
Focuses: Cc:

Description

Akismet uses __ngettext() which is deprecated and should be replaced with _n()

Line 932 and line 942 of akismet.php. I won't patch it as Akismet is an external.

Attachments (1)

akismet-notices-nacin.diff (12.1 KB) - added by nacin 7 years ago.

Download all attachments as: .zip

Change History (9)

#1 @johnbillion
7 years ago

  • Summary changed from Deprecated function in Akismet to Deprecated functions in Akismet

Oh we've got _c() in there too (replaced by _x()). Line 951.

#2 @johnbillion
7 years ago

Actually it's just ocurred to me that these are probably in here to maintain backwards compatibility. Feel free to close as wontfix.

#3 @dd32
7 years ago

  • Milestone changed from Unassigned to WordPress.org site

This should be reported to the Plugins trac, It would however be nice, if someone was to handle the tickets created there for Akismet

#4 @nacin
7 years ago

A few weeks ago, I submitted a patch to ryan that updates Akismet to use 3.0 code (while maintaining back compat to the earliest of versions). I believe it was passed onto the Akismet team at Automattic.

#5 follow-up: @jacobsantos
7 years ago

Really? I submitted a ticket to use file level docs a year ago and if it hasn't been committed, then I'll be darned. Probably should email it to Ryan instead of depending on the Plugins Trac.

#6 in reply to: ↑ 5 @jacobsantos
7 years ago

Replying to jacobsantos:

Really? I submitted a ticket to use file level docs a year ago and if it hasn't been committed, then I'll be darned. Probably should email it to Ryan instead of depending on the Plugins Trac.

LOL http://plugins.trac.wordpress.org/ticket/920 I guess 19 months ago.

#7 @solarissmoke
7 years ago

  • Cc solaris.smoke@… added

#8 @scribu
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I think this is fixed now.

Note: See TracTickets for help on using tickets.