Plugin editor falls over if no plugins are installed

[solarissmoke]

To reproduce:
Delete all plugins and then try to visit plugin editor.

[solarissmoke]

wp-die if no plugins installed. Also removed some superfluous <p> tags from another wp-die statement

[nacin]

In addition to the wp_die(), maybe we should hide the Editor menu item if no plugins are installed?

Also, terminology change in 3.0: blog => site. Clearly we haven't gotten to the other wp_die either.

[solarissmoke]

Don't display plugin editor link when no plugins installed; wp-die plugin editor when no plugins installed; change "blog" -> "site"

[solarissmoke]

Replying to nacin:

maybe we should hide the Editor menu item if no plugins are installed?

I agree - changed the patch. Changed "blog" to "site" also.

[nacin]

[14290]

[ryan]

Do we really want to run get_plugins() on every admin page load? It can be really slow.

[ryan]

(In [14299]) Don't call get_plugins() in menu.php. It is too slow to call on every admin page load. fixes #13117

[ryan]

Reverted the get_plugins() call. In the past it has caused notable slowness when called for every page load.

[dd32]

Don't we have a Transient with the Slugs of installed plugins that we could use here?

[solarissmoke]

Replying to dd32:

Don't we have a Transient with the Slugs of installed plugins that we could use here?

Indeed we do!

[solarissmoke]

Hopefully this will be better?

[nacin]

If we're going to do that, then if the transient === false, we should assume the blog has plugins. A) The transient may be expired, B) there is no guarantee the dashboard widget that controls it is registered.

[solarissmoke]

Yeah I realised that that could be a problem just after uploading the patch. I've changed it to check for === false.

[solarissmoke]

On the other hand, I'm beginning to think that it's not worth adding extra overhead just to show/hide the plugin editor link. Maybe it's better just left at [14299].