?p=xxx no longer redirects to ?page_id=xxx for Pages

[ryan]

WP 2.9 redirects ?p= requests for pages to a ?page_id request. 3.0 issues a 404 instead.

[ryan]

demetris tracked this down to [13315], which looks to have done this purposefully. I think a canonical redirect would be nice here.

[solarissmoke]

How does this patch look? It works for me, both with/without pretty permalinks enabled.

[solarissmoke]

Redirect p=NNN requests to page_id=NNN when a page with that ID exists

[night815]

small format changes to adhere to the coding standards

[night815]

I added a new patch that change "if(" to "if (". I did notice that your patch seemed to add an extra line at the end of the file. my patch doesn't even though it's still in my file. Is this because the trunk was already updated with that change?

anyways, I also tested this patch and it works.

[nacin]

The line at the end of the file is just line endings. It gets cleaned up upon commit.

[dd32]

(In [14355]) Serve a canonical redirection for ?p=, ?page_id=, ?attachment_id= url's for incorrect post_types (ie. ?p=<page_id> will redirect to that page url). Fixes #13125

[dd32]

Needs some more changes here, Specifically, ?p=<revision_ID> will attempt a redirect to invalid url's (Or at least, url's that the user should not see):
{{
?p=5 redirects to ​http://localhost/wordpress-commit/index.php/blog/2010/05/3-revision/
}}}

[solarissmoke]

Don't attempt to redirect to revisions

[solarissmoke]

Patch to check for revisions - although:

Are post revisions ever meant to be directly accessible? (the only way I can currently find to access them is through the diff viewer). If not, then link-template.php could be modified to check for this along with drafts/auto-drafts/pending:

Line 117

if ( '' != $permalink && !in_array($post->post_status, array('draft', 'pending', 'auto-draft')) && 'revision' != $post->post_type )

[nacin]

Those post_status checks should instead use get_post_stati.

[ryan]

(In [14595]) Attempt canonical redirect only for public post types. Props solarissmoke. see #13125

[ryan]

Good enough? Reopen if there's more that needs to be done.

[me_bruch]

This is a regression now as of version 4.3

[knutsp]

This ticket was closed on a completed milestone.
If you have a bug or enhancement to report, please open a new ticket. Be sure to mention this ticket, #13125.