WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13134 closed defect (bug) (fixed)

Menus admin styling adjustments

Reported by: filosofo Owned by: filosofo
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords:
Focuses: Cc:

Description (last modified by filosofo)

From Jane on IRC:

  • slidedown with arrow instead of edit/delete links
  • make right column wider width so it doesn't have to change on expansion (or fluid, whatever)
  • styling for the settings bit at top of right column
  • not default to search
  • are we doing most recent for pages? for both pages and cats it might be more useful than most used, b/c they'll likely go there when they add a new one, to add to menu
  • can height of the modules on left column be determined by content rather than min height?

Attachments (14)

13134.1.patch (9.0 KB) - added by koopersmith 4 years ago.
13134.2.patch (9.0 KB) - added by koopersmith 4 years ago.
13134.3.patch (9.2 KB) - added by koopersmith 4 years ago.
13134.4.patch (9.1 KB) - added by koopersmith 4 years ago.
13134.5.patch (8.5 KB) - added by koopersmith 4 years ago.
13134-plus-tab-text.diff (1.2 KB) - added by ryan 4 years ago.
Text for + tab
ui-in-progress.1.png (117.8 KB) - added by koopersmith 4 years ago.
ui-in-progress.2.png (121.3 KB) - added by koopersmith 4 years ago.
ui-in-progress.3.png (132.5 KB) - added by koopersmith 4 years ago.
13134.ui.1.patch (42.5 KB) - added by koopersmith 4 years ago.
13134.ui.2.patch (45.7 KB) - added by koopersmith 4 years ago.
13134.create.css.patch (1.6 KB) - added by koopersmith 4 years ago.
13134.item.delete.css.patch (672 bytes) - added by koopersmith 4 years ago.
13134-create_menu_text.diff (2.2 KB) - added by duck_ 4 years ago.

Download all attachments as: .zip

Change History (39)

comment:1 filosofo4 years ago

  • Description modified (diff)

comment:2 koopersmith4 years ago

Also, we should assign the right column a max/fixed width so it doesn't fly to the bottom of the page when you edit an item (it's quite confusing, I know from experience!).

koopersmith4 years ago

comment:3 koopersmith4 years ago

Patch of what I have so far.

  • Right column is fluid, with a max-width of 600
  • "height of the modules on left column determined by content rather than min height"
  • Arrows appear permanently on add item boxes (instead of only on hover).
  • (JS) Add menu item boxes slide up and down instead of instantly expanding/contracting. The second patch has a faster expansion speed.

koopersmith4 years ago

koopersmith4 years ago

comment:4 koopersmith4 years ago

Fixed bug where add menu item boxes required two clicks to open & wouldn't save open/closed state.

koopersmith4 years ago

comment:5 koopersmith4 years ago

Left a stray console.log in there. Silly me.

koopersmith4 years ago

comment:6 koopersmith4 years ago

Removed the sliding, because IE6 ruined the party. Sliding moved to #13147.

comment:7 ryan4 years ago

(In [14252]) Menu styling updates. Props koopersmith. see #13134

comment:8 filosofo4 years ago

I'm going to put this in a separate ticket because it needs a backend API change:

  • are we doing most recent for pages? for both pages and cats it might be more useful than most used, b/c they'll likely go there when they add a new one, to add to menu

ryan4 years ago

Text for + tab

comment:9 follow-up: ryan4 years ago

(In [14254]) Explanatory text for the plus tab. see #13134

koopersmith4 years ago

koopersmith4 years ago

koopersmith4 years ago

comment:10 ocean904 years ago

  • Cc ocean90@… added

Some small things from me:

  • change the button text of the + tab to Create Menu
  • add no opacity to the menu-item-settings section
  • remove max-width: 600px; (or increase) from #menu-management, it looks weird on widescreens

comment:11 nacin4 years ago

(In [14283]) More nav menu fixes. props filosofo. see #13148. fixes #13155, fixes #13157, fixes #13138, see #13134.

koopersmith4 years ago

comment:12 koopersmith4 years ago

Still a few bugs. Working them out.

koopersmith4 years ago

comment:13 nacin4 years ago

(In [14286]) Nav menu UI updates. props koopersmith, see #13134.

comment:14 nacin4 years ago

(In [14287]) Nav menu UI updates. props koopersmith, see #13134.

comment:15 nacin4 years ago

(In [14288]) Small fixes to the initial nav menu message. props koopersmith, see #13134.

comment:16 nacin4 years ago

(In [14293]) Fix the ajax loading/processing spinner for nav menu meta boxes. see #13134.

comment:17 nacin4 years ago

(In [14294]) Fix typo in CSS. see #13134.

comment:18 ryan4 years ago

(In [14297]) Set nopaging for the wp_get_nav_menu_items() get_posts() call to avoid pointless found rows queries. see #13134

comment:19 ryan4 years ago

(In [14301]) Partially fix default hidden meta boxes for nav menus. see #13134

comment:20 ryan4 years ago

(In [14304]) Fix initial hidden meta boxes for nav menus. see #13134

comment:21 nacin4 years ago

(In [14314]) Small menu CSS tweak for item deletion. props koopersmith, see #13134.

comment:23 in reply to: ↑ 9 duck_4 years ago

Replying to ryan:

(In [14254]) Explanatory text for the plus tab. see #13134

The text doesn't fully reflect the current actions you have to perform when creating a menu. As far as I can tell you have to save the menu before you can add items to it, the instructions seem to suggest that you can type in a name and start adding items immediately and after that click save.

To this effect small patch to change the button text to "Create Menu" on the plus tab and a few minor changes to instructions.

Not a major issue, but I think that strings for menus need to be completed soon for translators.

comment:24 nacin4 years ago

(In [14333]) Clarify menu creation versus save. props duck_, see #13134. Check in scripts for r14332, see #13204.

comment:25 koopersmith4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing, and relocating the only item left to #13217 ("Use most recent instead of most used in add menu item boxes").

Note: See TracTickets for help on using tickets.