WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#13135 closed defect (bug) (fixed)

Admin menu non-js ordering needs some work

Reported by: filosofo's profile filosofo Owned by: filosofo's profile filosofo
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: needs-patch
Focuses: Cc:

Description

The algorithm for moving a menu item down should work and be the converse of that for moving a menu item up.

Attachments (2)

13135-nonces_fix.diff​ (807 bytes) - added by duck_ 16 years ago.
Allow it to work at all
non-js-menu-ordering.13135.diff​ (20.4 KB) - added by filosofo 16 years ago.

Download all attachments as: .zip

Change History (6)

@duck_
16 years ago

Allow it to work at all

#1 @ocean90
16 years ago

  • Keywords needs-patch added

duck_: There must be more as the nonces problem.

#2 @filosofo
16 years ago

  • Status changed from new to assigned

@filosofo
16 years ago

#3 @filosofo
16 years ago

Patch non-js-menu-ordering.13135.diff works both up and down for my non-js menu testing.

Note:

  • This uses the yet-uncommitted code in #13249
  • You may (although possibly not) need to delete your menu's items and re-add to get it to work properly, depending on when in the dev cycle they were created.

#4 @nacin
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14450]) Non-JS menu ordering fixes, also parent handling fixes. props filosofo, fixes #13135, fixes #13249

Note: See TracTickets for help on using tickets.