WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13143 closed defect (bug) (fixed)

Problems with add-menu-item boxes

Reported by: ocean90 Owned by: filosofo
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords:
Focuses: Cc:

Description

A few things which I have noticed:

  • The search only works once. Search for a and you get a result, search then for somethinkthatdoesntexsits and you get the same result
  • the Media box doesn't work, neither search nor view all
  • we should remove Add from the title of the boxes (as on write post/page)
  • Go to the page(or post) box, then tab view all, check one, then go to the tab search and click the search button, now you should get the menu item which you have checked.
  • when you search, the loading gif appears in all boxes (should that be so?)

Attachments (1)

misc.13143.diff (6.2 KB) - added by filosofo 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @filosofo5 years ago

  • Status changed from new to accepted

comment:2 in reply to: ↑ description @filosofo5 years ago

Replying to ocean90:

  • the Media box doesn't work, neither search nor view all

This is being handled in #13148 so I didn't include here.

  • we should remove Add from the title of the boxes (as on write post/page)

Jane did agree with this in IRC, so I removed for patch.

  • Go to the page(or post) box, then tab view all, check one, then go to the tab search and click the search button, now you should get the menu item which you have checked.

I disagree. If you click search on an empty search box you shouldn't get any results.

@filosofo5 years ago

comment:3 @nacin5 years ago

(In [14267]) Some menus meta box cleanups. props filosofo, see #13143.

comment:4 follow-up: @filosofo5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

I'm going to close as fixed, but if ocean90 you think the view all thing still needs to be addressed, please re-open.

comment:5 @nacin5 years ago

I hate the checkboxes, personally, and would rather see them disappear for JS.

comment:6 in reply to: ↑ 4 ; follow-up: @ocean905 years ago

Replying to filosofo:

I'm going to close as fixed, but if ocean90 you think the view all thing still needs to be addressed, please re-open.

Yep, it still exists:
Go to the post box, view all tab, now check one of the posts. After that go to the search tab and click the button search. Now you should get a new menu item to the menu, it's the checked post from the tab view all.

comment:7 @ocean905 years ago

  • Cc ocean90@… added
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 in reply to: ↑ 6 @filosofo5 years ago

Replying to ocean90:

Go to the post box, view all tab, now check one of the posts. After that go to the search tab and click the button search. Now you should get a new menu item to the menu, it's the checked post from the tab view all.

I misunderstood: I thought by "should" that you were saying that was the expected behavior; instead you meant that it is the current behavior.

comment:9 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.