Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#13153 closed defect (bug) (fixed)

Bulk Edit overrites non hierarchical taxonomies

Reported by: prettyboymp's profile prettyboymp Owned by: nacin's profile nacin
Milestone: 3.0 Priority: high
Severity: blocker Version:
Component: Taxonomy Keywords: has-patch, tested, commit
Focuses: Cc:

Description

When bulk editing posts, leaving the post_tags field blank causes all the tags to be deleted for the updated posts. Bulk editing taxonomies should only be additive like it is with hierarchical taxonomies.

To reproduce:

  1. Set tags for a post
  2. Bulk edit that post, but don't make any changes.
  3. Hit Update.

The tags have been removed from the post.

Attachments (1)

13153.patch (1.6 KB) - added by prettyboymp 15 years ago.

Download all attachments as: .zip

Change History (11)

#1 @nacin
15 years ago

  • Owner changed from filosofo to nacin
  • Status changed from new to assigned

I'm guessing this was the result of one of my changesets.

@prettyboymp
15 years ago

#2 @prettyboymp
15 years ago

  • Cc mpretty@… added
  • Keywords has-patch added

#3 @scribu
15 years ago

Related: [14230]

#4 @nacin
15 years ago

When reading this I had thought [14117] would be the culprit.

#5 @dd32
15 years ago

  • Milestone 3.0 deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

This may be related to my fix for #10122, But this appears to work for me.

If i add a tag, or custom flat tax term of 'OVERWRITE' or leave it blank, it simply adds or retains the current term list...

If you can still see the problem, please re-open this.

#6 @dd32
15 years ago

  • Milestone set to 3.0
  • Resolution worksforme deleted
  • Status changed from closed to reopened

Ok, I was wrong. I can confirm this bug still exists, Not sure why it appeared to work correctly.

#7 @jeffstieler
15 years ago

  • Keywords tested commit added

#8 @ryan
15 years ago

  • Severity changed from normal to blocker

#9 @ryan
15 years ago

Reproduced problem without patch. Tested the following with patch:

  • Add tags and cats via edit form
  • Remove tags and cats via edit form
  • Add via quick edit
  • Remove via quick edit
  • Add via bulk edit, verify new terms are additive, verify no terms are removed

#10 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.