WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13187 closed enhancement (fixed)

Twenty Ten support for Plural Forms

Reported by: zeo Owned by: nbachiyski
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

There are some language (read: Russian) that require plural forms for some string.

See: http://code.google.com/p/kaytwo-i18n/issues/detail?id=1

The question is, does twentyten need to support this?

Attachments (1)

twentyten-plural-forms-comments.diff (1.1 KB) - added by zeo 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 follow-up: nacin4 years ago

Isn't that the purpose of the 3 different strings passed to comments_number()?

comment:2 in reply to: ↑ 1 dimadin4 years ago

  • Cc dimadin added

Replying to nacin:

Isn't that the purpose of the 3 different strings passed to comments_number()?

No, with current code, it is asumed that all languages use same word for plural but that is not case. You can see example in link zeo left:

2 комментария

3 комментария

4 комментария

5 комментариев

You can read more about it here. (examples start at "The following rules are known")

Only thing I would change in zeo's patch is that it would be better to use on prinbt functions instead of two.

comment:3 zeo4 years ago

nacin, at first I really thought comments_number() would do the job, but then came that ticket on kaytwo-i18n.

dimadin, if u have better patch by all means please share ;)

For the record, we won't be needing "No Responses" string since the comment section only displayed when there's a comment/ping/trackback. see: if ( have_comments() ).

Any l10n, i18n ninja here?

comment:4 nacin4 years ago

  • Owner set to nbachiyski
  • Status changed from new to assigned

comment:5 nbachiyski4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14358]) Use _n() instead of comments_number() in twentyten, because it doesn't handle plurals properly. Props zeo and dimadin. Fixes #13187

Note: See TracTickets for help on using tickets.