Opened 5 years ago
Closed 5 years ago
#13190 closed defect (bug) (fixed)
Make menus UI work with blue admin theme
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.0 | Priority: | normal |
| Severity: | blocker | Version: | 3.0 |
| Component: | Menus | Keywords: | has-patch |
| Focuses: | Cc: |
Description
Namely, the menu items/menu box. See http://twitpic.com/1jmvxo/full
Attachments (4)
Change History (13)
comment:3
follow-up:
↓ 4
@kpdesign
— 5 years ago
Thanks duck. I tested your patch and it takes care of changing the main header from gray to blue but did not change the menu items underneath. I've attached an updated patch (against rev. 14462) that includes your changes and a few others to take care of the menu items as well.
comment:4
in reply to:
↑ 3
;
follow-up:
↓ 5
@duck_
— 5 years ago
Replying to kpdesign:
Thanks duck. I tested your patch and it takes care of changing the main header from gray to blue but did not change the menu items underneath.
The only reason I didn't change those was because in most other boxes (e.g. meta boxes) the content inside the box stays the same regardless of the theme, but I guess see what others say.
comment:5
in reply to:
↑ 4
;
follow-up:
↓ 6
@kpdesign
— 5 years ago
Replying to duck_:
The only reason I didn't change those was because in most other boxes (e.g. meta boxes) the content inside the box stays the same regardless of the theme, but I guess see what others say.
My updated patch doesn't change the background color of the content area inside the meta boxes, just the header background image for the meta box title inside the menu box.
I added 2 screenshots to the ticket. First one is the screenshot linked to when ticket was created; the second one is the menu UI after applying your changes and mine (patch 13190.1).
comment:6
in reply to:
↑ 5
;
follow-up:
↓ 7
@duck_
— 5 years ago
Replying to kpdesign:
My updated patch doesn't change the background color of the content area inside the meta boxes, just the header background image for the meta box title inside the menu box.
Sorry wasn't clear enough, I understood what you meant and I think it looks nicer that way. Was just explaining why I hadn't done it in the first place (was talking about things such as "most popular"/"view all" tabs in meta boxes).
comment:7
in reply to:
↑ 6
@kpdesign
— 5 years ago
Replying to duck_:
Sorry wasn't clear enough, I understood what you meant and I think it looks nicer that way. Was just explaining why I hadn't done it in the first place (was talking about things such as "most popular"/"view all" tabs in meta boxes).
I agree with you on the "most popular/view all" tabs inside the meta boxes. Those need to stay as they are now.
I guess we're ready to have a dev take a look at this now?
Patch above...
Also changed background for top of editor in classic theme (see when kitchen sink is open)