Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13204 closed task (blessed) (fixed)

Fix ajax on add menu item boxes

Reported by: koopersmith Owned by: filosofo
Milestone: 3.0 Priority: high
Severity: blocker Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:


The ajax that switched between add menu item tabs was broken and causing a reload.

The patch fixes switching between tabs, but clicking on links to view paged results (in view all) still causes reloads.

Attachments (4)

13204.fix.tabs.1.patch (519 bytes) - added by koopersmith 5 years ago.
13204.ajax.improvements.1.patch (9.6 KB) - added by koopersmith 5 years ago.
13204.one.call.multiple.items.1.patch (7.8 KB) - added by koopersmith 5 years ago.
ajaxy-pagification-of-meta-boxes.13204.diff (6.6 KB) - added by filosofo 5 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 @nacin5 years ago

(In [14332]) Fix ajax on add menu item boxes. props koopersmith, see #13204

comment:2 @nacin5 years ago

(In [14333]) Clarify menu creation versus save. props duck_, see #13134. Check in scripts for r14332, see #13204.

comment:3 @duck_5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 @koopersmith5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Paged results still cause reloads, and need to be ajaxified.

comment:5 @nacin5 years ago

  • Priority changed from normal to high
  • Type changed from defect (bug) to task (blessed)

comment:6 @nacin5 years ago

(In [14464]) Consolidate nav menu item ajax. Other misc fixes. props koopersmith, see #13204.

comment:7 @koopersmith5 years ago

Latest patch shifts jQuery extensions into their own function and modifies the addSelectedToMenu extension to make one ajax call instead of one per item.

comment:8 @nacin5 years ago

one.call.multiple.items.1.patch was committed in [14468]

comment:9 @ryan5 years ago


comment:10 @koopersmith5 years ago

We still need to add ajax for paged results, but since we're using checkboxes it's less of an issue. That said, if a user clicks on a page link they will lose the menu order (as it equates to a no-save, see #13337) so this is probably worth adding for 3.0.

comment:11 @nacin5 years ago

  • Severity changed from normal to blocker

With the AYS now, it's required for 3.0.

comment:12 @filosofo5 years ago

  • Owner changed from koopersmith to filosofo
  • Status changed from reopened to accepted

Doing ajax pages.

comment:13 @filosofo5 years ago

  • Keywords has-patch added

ajaxy-pagification-of-meta-boxes.13204.diff makes the paginated meta-box links ajaxified.

comment:14 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14943]) Ajaxify pagination requests in menu boxes. Props filosofo. fixes #13204

Note: See TracTickets for help on using tickets.