Opened 15 years ago
Closed 15 years ago
#13220 closed defect (bug) (fixed)
Nav Menus 3.0 Code Sprint
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.0 | Priority: | normal |
| Severity: | normal | Version: | 3.0 |
| Component: | Menus | Keywords: | |
| Focuses: | Cc: |
Description
Working ticket for the nav menus 3.0 code sprint.
Attachments (30)
Change History (54)
#3
follow-up:
↓ 4
@
15 years ago
The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?
In my opinion, yes I think it would!
#4
in reply to:
↑ 3
@
15 years ago
Replying to markmcwilliams:
The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?
In my opinion, yes I think it would!
Having the menu items as fixed width makes sense because it means that the input boxes aren't stretched out or look too short within the box (like they would be if the item box was full width). It probably also gives a little bit more distinction to the nested items as well.
#5
follow-up:
↓ 11
@
15 years ago
Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.
#8
follow-up:
↓ 9
@
15 years ago
- Priority changed from normal to high
- Type changed from enhancement to defect (bug)
i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)
sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today
#9
in reply to:
↑ 8
@
15 years ago
- Priority changed from high to normal
Replying to LazyMe:
i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)
sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today
define ('CONCATENATE_SCRIPTS', false);
if false, it works again - if true it depends on the blog.. strange. (since today - trunk)
#10
follow-up:
↓ 13
@
15 years ago
define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.
#11
in reply to:
↑ 5
@
15 years ago
Replying to jane:
Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.
Fair enough! :)
#13
in reply to:
↑ 10
@
15 years ago
Replying to nacin:
define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.
i`m stupid - thanks for the information, nacin.
#17
@
15 years ago
Missed a variable in js.warnings.begone.1.patch, was causing a bug in select all. Fixed above.
#22
@
15 years ago
See #13311
Another thing: http://grab.by/4hLW If a post/page has no title we should add (no title) as menu label
changes "text" to "label" for the custom links metabox. corrects the alignment for list-controls links