WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#13220 closed defect (bug) (fixed)

Nav Menus 3.0 Code Sprint

Reported by: ptahdunbar Owned by: ptahdunbar
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords:
Focuses: Cc:

Description

Working ticket for the nav menus 3.0 code sprint.

Attachments (30)

nav_menu_tweaks.diff (1.5 KB) - added by ptahdunbar 6 years ago.
changes "text" to "label" for the custom links metabox. corrects the alignment for list-controls links
toggle_select.diff (1.1 KB) - added by ptahdunbar 6 years ago.
toggle the "select all" link to check or uncheck links
menu_items_dupe_class.diff (1.3 KB) - added by duck_ 6 years ago.
remove dupe class attr (cannot find it referenced elsewhere either)
truncate.menu.names.1.patch (1.4 KB) - added by koopersmith 6 years ago.
truncate.menu.names.2.patch (1.4 KB) - added by koopersmith 6 years ago.
truncate.menu.names.3.patch (1.4 KB) - added by koopersmith 6 years ago.
13220.remove.unneeded.css.1.patch (954 bytes) - added by koopersmith 6 years ago.
nav_menu_js.diff (5.8 KB) - added by ptahdunbar 6 years ago.
splits up the submission forms so they can be invoked individually.
nav_menu_js.2.diff (7.3 KB) - added by ptahdunbar 6 years ago.
same as previous patch, but based on r14434 not r14433
nav_menu_js.3.diff (7.4 KB) - added by koopersmith 6 years ago.
13220.select.all.1.patch (2.8 KB) - added by koopersmith 6 years ago.
add_home_link_hawtness.diff (5.3 KB) - added by ptahdunbar 6 years ago.
"Add Home Link" feature, doesn't work without js yet
13220.add.home.link.and.friends.1.patch (7.4 KB) - added by koopersmith 6 years ago.
revert_deleting_item.diff (432 bytes) - added by duck_ 6 years ago.
revert accidental css removal in r14337
highlight_home_link.diff (618 bytes) - added by ptahdunbar 6 years ago.
highlights the home link in nav menus
highlight_home_link.2.diff (687 bytes) - added by ptahdunbar 6 years ago.
highlight_home_link.3.diff (699 bytes) - added by ptahdunbar 6 years ago.
highlight_home_link.4.diff (872 bytes) - added by ptahdunbar 6 years ago.
highlight_home_link.4.2.diff (1.2 KB) - added by ptahdunbar 6 years ago.
highlight_home_link.4.2.2.diff (1.2 KB) - added by ptahdunbar 6 years ago.
13220.js.warnings.begone.1.patch (2.7 KB) - added by koopersmith 6 years ago.
13220.select.all.var.fix.1.patch (1.1 KB) - added by koopersmith 6 years ago.
13220.remove.trailing.commas.1.patch (2.1 KB) - added by koopersmith 6 years ago.
13220.adopt.wp.js.standard.1.patch (10.3 KB) - added by koopersmith 6 years ago.
valid.patch (10.6 KB) - added by ocean90 6 years ago.
Markup Validation
13220.adopt.wp.js.standard.1.2.patch (10.3 KB) - added by koopersmith 6 years ago.
13220.move.add.home.link.1.patch (2.7 KB) - added by koopersmith 6 years ago.
sorting.improvements.progress.1.patch (5.8 KB) - added by koopersmith 6 years ago.
sorting.improvements.progress.2.patch (1.4 KB) - added by koopersmith 6 years ago.
sortable.groups.improvements.2.patch (4.1 KB) - added by koopersmith 6 years ago.

Download all attachments as: .zip

Change History (54)

#1 @ptahdunbar
6 years ago

  • Milestone changed from Unassigned to 3.0
  • Version set to 3.0

@ptahdunbar
6 years ago

changes "text" to "label" for the custom links metabox. corrects the alignment for list-controls links

#2 @ryan
6 years ago

(In [14352]) Nav menu tweaks. Props ptahdunbar. see #13220

#3 follow-up: @markmcwilliams
6 years ago

The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?

In my opinion, yes I think it would!

@ptahdunbar
6 years ago

toggle the "select all" link to check or uncheck links

#4 in reply to: ↑ 3 @duck_
6 years ago

Replying to markmcwilliams:

The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?

In my opinion, yes I think it would!

Having the menu items as fixed width makes sense because it means that the input boxes aren't stretched out or look too short within the box (like they would be if the item box was full width). It probably also gives a little bit more distinction to the nested items as well.

@duck_
6 years ago

remove dupe class attr (cannot find it referenced elsewhere either)

#5 follow-up: @jane
6 years ago

Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.

#6 @nacin
6 years ago

(In [14408]) Truncate really long menu names. props koopersmith, see #13220.

#7 @nacin
6 years ago

(In [14413]) Remove unused CSS. props koopersmith, see #13220

@ptahdunbar
6 years ago

splits up the submission forms so they can be invoked individually.

@ptahdunbar
6 years ago

same as previous patch, but based on r14434 not r14433

@ptahdunbar
6 years ago

"Add Home Link" feature, doesn't work without js yet

#8 follow-up: @LazyMe
6 years ago

  • Priority changed from normal to high
  • Type changed from enhancement to defect (bug)

i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)

sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today

#9 in reply to: ↑ 8 @LazyMe
6 years ago

  • Priority changed from high to normal

Replying to LazyMe:

i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)

sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today

define ('CONCATENATE_SCRIPTS', false);

if false, it works again - if true it depends on the blog.. strange. (since today - trunk)

#10 follow-up: @nacin
6 years ago

define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.

#11 in reply to: ↑ 5 @markmcwilliams
6 years ago

Replying to jane:

Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.

Fair enough! :)

@duck_
6 years ago

revert accidental css removal in r14337

#12 @ocean90
6 years ago

@LazyMe
Thanks, it's fixed in #9008

#13 in reply to: ↑ 10 @LazyMe
6 years ago

Replying to nacin:

define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.

i`m stupid - thanks for the information, nacin.

#14 @nacin
6 years ago

It actually was a bug of some sort, see #9008.

@ptahdunbar
6 years ago

highlights the home link in nav menus

#15 @nacin
6 years ago

(In [14457]) Check custom links, including a home link, against the current URL to see if we should add current-menu-item. props ptahdunbar, fixes #13213, see #13220.

#16 @nacin
6 years ago

(In [14467]) Minor JS var declaration optimizations. props koopersmith, see #13220.

#17 @koopersmith
6 years ago

Missed a variable in js.warnings.begone.1.patch, was causing a bug in select all. Fixed above.

#18 @nacin
6 years ago

(In [14474]) Remove more trailing commas in nav menus JS. props koopersmith and ocean90, see #13220.

@ocean90
6 years ago

Markup Validation

#19 @nacin
6 years ago

(In [14475]) Adopt WP's general JS structure. Remove last of trailing commas. Remove dead code. props koopersmith, see #13220.

#20 @nacin
6 years ago

(In [14482]) Ensure valid HTML in the nav menu UI. props ocean90, see #13220.

#21 @nacin
6 years ago

(In [14520]) Allow menu items to be dropped on a parent item in addition to just being dragged to the right. props koopersmith, see #13220.

#22 @ocean90
6 years ago

See #13311

Another thing: http://grab.by/4hLW If a post/page has no title we should add (no title) as menu label

#23 @nacin
6 years ago

(In [14531]) Some sortable improvements in the nav menu UI. props koopersmith, see #13220.

#24 @ryan
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.