WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#13230 closed defect (bug) (fixed)

_check_theme_deprecated_files() wording is incorrect

Reported by: greenshady Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords:
Focuses: Cc:

Description

I'd like to open this up for more discussion on what constitutes an "incomplete" theme. My themes don't use a sidebar.php file and are by no means incomplete. This message is incorrect and will be confusing to my users:

The current theme is incomplete as it is missing sidebar.php. Please update your theme to include these files as you are currently relying on deprecated behaviour.

This is regarding changeset 14369:
http://core.trac.wordpress.org/changeset/14369

Simply because a file doesn't exist doesn't mean a theme is incomplete nor does it mean that a theme is relying on deprecated behavior. I might be able to understand header.php and footer.php a little more (though they aren't required), but sidebar.php shouldn't ever be thought of as a requirement. Ever used a single-column theme?

I either propose removing the message or updating the wording to something that is correct.

Change History (6)

comment:1 @scribu5 years ago

Simply because a file doesn't exist doesn't mean a theme is incomplete nor does it mean that a theme is relying on deprecated behavior.

I agree. The correct way to check for deprecated behaviour (i.e. relying on files from the old default theme) would involve seeing if any of those files are actually used anywhere in the theme.

comment:2 @westi5 years ago

If someone wants to come up with a better way of checking a patch would be very welcome.

For now I will disable the checks.

comment:3 @westi5 years ago

(In [14411]) Remove the deprecation message for now as it shows too many false positives. See #13230.

comment:4 @nacin5 years ago

  • Milestone changed from 3.0 to 3.1

comment:5 @hakre4 years ago

Related: #14999

comment:6 @nacin4 years ago

  • Milestone changed from Awaiting Triage to 3.0
  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed on 3.0.

Note: See TracTickets for help on using tickets.