Changes between Initial Version and Version 1 of Ticket #13239, comment 68
- Timestamp:
- 02/18/2014 01:49:06 AM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13239, comment 68
initial v1 2 2 > How about casting `$template_names` to an array within the filter on line 475? 3 3 4 Funny, that was how I wrote it initially. I reverted because I didn't want the filter to have to check for a one element array with no value which is what would happen if false, or an empty stringwas passed ''(which admittedly would be a very rare edge case.)''4 Funny, that was how I wrote it initially. I reverted because I didn't want the filter to have to check for a one element array with no value which is what would happen if a false value or an empty string value was passed ''(which admittedly would be a very rare edge case.)'' 5 5 6 6 > We could omit the `false === $template_names` check and remove the typecasting from the foreach loop, while not changing the outcome for the function.