Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#13257 closed defect (bug) (duplicate)

Pass $post to post_type_link filter, instead of $id

Reported by: bigdawggi's profile bigdawggi Owned by: nacin's profile nacin
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: General Keywords: needs-patch
Focuses: Cc:


To keep with the standard set by the filter 'post_link' inside the get_permalink() function, should the second parameter of the 'post_type_link' be the $post, instead of the $id?

attached is the proposed diff

Attachments (1)

post-type-link-filter.diff (516 bytes) - added by bigdawggi 13 years ago.

Download all attachments as: .zip

Change History (4)

#1 @hakre
13 years ago

  • Keywords needs-patch added; filter post-type removed

I like the idea (makes sense) but patch is stale.

Related: #12526 (for mixed/optional post argument)

#2 @nacin
13 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

#3 @nacin
13 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from reviewing to closed

This was actually fixed via a different ticket, #14299, and was backported to 3.0.

Note: See TracTickets for help on using tickets.