WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13293 closed defect (bug) (fixed)

In Twenty Ten, use square brackets syntax to filter wp_page_menu_args

Reported by: demetris Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

The filter introduced in r14469 unsets default wp_page_menu args, which causes “Undefined index” warnings.

Patch fixes that.

Attachments (2)

t13293-twentyten-square-brackets-syntax.diff (765 bytes) - added by demetris 5 years ago.
Square brackets syntax for filtering wp_page_menu_args from Twenty Ten
t13293-twentyten-square-brackets-syntax-r002.diff (649 bytes) - added by demetris 5 years ago.
Square brackets syntax for filtering wp_page_menu_args from 2010, and removal of unneeded bits

Download all attachments as: .zip

Change History (4)

@demetris5 years ago

Square brackets syntax for filtering wp_page_menu_args from Twenty Ten

comment:1 @demetris5 years ago

Just realized that the original array simply repeats some defaults.

Attaching new patch that keeps only what is necessary.

@demetris5 years ago

Square brackets syntax for filtering wp_page_menu_args from 2010, and removal of unneeded bits

comment:2 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14500]) Properly handle the wp_page_args filter in Twenty Ten. fixes #13293, props demetris.

Note: See TracTickets for help on using tickets.