WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#13301 closed enhancement (fixed)

Improvements to UI for custom post types that are not publicy queryable

Reported by: johnbillion Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: minor Version: 3.0
Component: Posts, Post Types Keywords: has-patch needs-refresh
Focuses: Cc:

Description

When you register a custom post type with the 'publicly_queryable' parameter set to false, links in the UI to view the post should not be shown.

Patch coming up.

Attachments (1)

13301.patch (3.5 KB) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (11)

johnbillion4 years ago

comment:1 johnbillion4 years ago

Patch.

Patch looks substantial in the diff viewer but all it's doing is wrapping that block in a check for $post_type_object->publicly_queryable.

comment:2 johnbillion4 years ago

  • Keywords has-patch added

comment:3 kevinB4 years ago

  • Cc kevinB added

comment:4 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

Ah ha. I knew this ticket existed. A few more areas are patched in #14827, but they should be publicly_queryable.

comment:5 markjaquith3 years ago

  • Keywords 3.2-early added
  • Milestone changed from 3.1 to Future Release

comment:6 johnbillion3 years ago

Any reason this was bumped? It's a trivial patch. I'll refresh if necessary.

comment:7 scribu3 years ago

  • Keywords needs-refresh added; 3.2-early removed
  • Milestone changed from Future Release to 3.2

Small enough patch and will probably be even smaller after refresh.

comment:8 jane3 years ago

  • Milestone changed from 3.2 to Future Release

No refreshed patch before freeze, punting.

comment:9 nacin3 years ago

  • Milestone changed from Future Release to 3.2

This is actually a bug, and a straightforward change, so handling this.

comment:10 nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [17899]:

Don't show broken 'View' links when a CPT isn't publicly queryable. fixes #13301, props johnbillion.

Note: See TracTickets for help on using tickets.