WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#13326 closed defect (bug) (fixed)

WordPress does not function on iPad in View (non HTML Mode)

Reported by: Astriker Owned by:
Milestone: 3.0.1 Priority: normal
Severity: normal Version: 3.0
Component: Editor Keywords: has-patch needs-testing
Focuses: Cc:

Description

I just thought I would pass on that I noticed when editing wordpress or creating blogs on the ipad browser, you cannot select the contect area of the body. It does not recognize it as a text field. I can select HTML and enter it there. This appears to be the only field that the safari browser does not identify as a field. May be apples problem, but passing along.

Attachments (2)

13326.patch (635 bytes) - added by azaozz 11 years ago.
13326.1.diff (776 bytes) - added by simonwheatley 11 years ago.
Adds $is_iphone to the global declaration

Download all attachments as: .zip

Change History (19)

#1 @nacin
12 years ago

  • Component changed from General to Editor
  • Milestone changed from 3.0 to Unassigned

A bit late for 3.0. Moving to unassigned for now. I have a feeling this is a side effect of that it is a content editable space, and thus we can't do much about it.

#2 @toscho
12 years ago

  • Cc toscho added

The iPad doesn’t support contenteditable.

Maybe we could replace the element with a textarea after a check?

if(typeof(element.contentEditable) != 'undefined')
// modern content
else
// fallback

#3 follow-up: @jane
12 years ago

Also, there is an iPad-native WordPress app.

#4 @azaozz
12 years ago

Although it doesn't look like it this is actually related to #13327. We can try to detect whether the browser doesn't have JS enabled or doesn't support other features needed by the editor and fall back to plain textarea with the proper filters applied.

Also perhaps the ipad browser will be updated to the full Safari functionality in the future.

#5 in reply to: ↑ 3 ; follow-up: @Astriker
12 years ago

Replying to jane:

Also, there is an iPad-native WordPress app.

I am not aware of an iPad native, I am just using the current WP admin console that comes with it. It notices the Subject with no problem, only the area it does not. Is the iPad version app available or is it the iPhone version?

#6 @dd32
11 years ago

  • Milestone changed from Unassigned to 3.1

Also perhaps the ipad browser will be updated to the full Safari functionality in the future.

I somewhat doubt it'll happen anytime soon.

It would probably be best to disable TinyMCE for $is_iphone?

#7 in reply to: ↑ 5 ; follow-up: @nacin
11 years ago

Replying to Astriker:
Is the iPad version app available or is it the iPhone version?

There is a WordPress for iOS app that works for iPhone, iPad, and iPod touch.

http://iphone.wordpress.org

#8 in reply to: ↑ 7 @astriker
11 years ago

Replying to nacin:

Replying to Astriker:
Is the iPad version app available or is it the iPhone version?

There is a WordPress for iOS app that works for iPhone, iPad, and iPod touch.

http://iphone.wordpress.org

I have the wordpress for iphone all setup, but I was hoping to use the full version in Safari, which is more of the iPad usage.

#9 follow-up: @simonwheatley
11 years ago

  • Cc simon@… added
  • Keywords has-patch dev-feedback needs-testing added

TinyMCE release v3.3.4 addressed this (http://tinymce.moxiecode.com/punbb/viewtopic.php?id=21314):

We also added detection logic for iPhone/iPad so that TinyMCE doesn't
get initialized on these devices. It's currently impossible for us to add
iPhone/iPad support since WebKit on these devices lacks any for of
caret within contentEditable areas. Even though this detection logic
will keep TinyMCE from being initialized it's recommended to do the
device checking on the server side since the main script of TinyMCE
will be loaded even though it can't be used.

I've created an incomplete patch which attempts to upgrade WP to TinyMCE v3.3.8, which is the current production release. Issues I've noticed with this patch:

  • The spellchecker button is blank
  • The align buttons don't work (error message: "TypeError: Result of expression 'c.editorCommands.mceJustify' [undefined] is not a function.")

Patch refinements welcome!

#10 in reply to: ↑ 9 ; follow-up: @azaozz
11 years ago

  • Milestone changed from Awaiting Triage to 3.1

Replying to simonwheatley:
TinyMCE will be upgraded to its latest version for WordPress 3.1, see #12574. I expect this will land in 3.1-alpha early in the next dev. cycle, probably early September.

Unfortunately that won't fix this issue completely. When editing a post we output the content slightly differently depending on whether the Visual or the HTML editor is loaded first. We should handle this in the back-end/PHP as the TinyMCE team suggests.

Patching this should be quite trivial, will add a proposed patch a bit later.

@azaozz
11 years ago

#11 @azaozz
11 years ago

  • Keywords dev-feedback removed

#12 in reply to: ↑ 10 @simonwheatley
11 years ago

Replying to azaozz:

Replying to simonwheatley:

Unfortunately that won't fix this issue completely. When editing a post we output the content slightly differently depending on whether the Visual or the HTML editor is loaded first. We should handle this in the back-end/PHP as the TinyMCE team suggests.

Patching this should be quite trivial, will add a proposed patch a bit later.

Fair enough. I think the patch needs $is_iphone to be global declaration at the top of the function... I'll post a patch shortly. Otherwise I've tested this on an iPad and it works, thanks!

Any chance we can get a nice small change like this into 3.0.1?

@simonwheatley
11 years ago

Adds $is_iphone to the global declaration

#13 @nacin
11 years ago

  • Milestone changed from 3.1 to 3.0.1

#14 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15460]) Disable the visual editor in iOS. props azaozz, simonwheatley. fixes #13326 for 3.1.

#15 @nacin
11 years ago

(In [15461]) Disable the visual editor in iOS. props azaozz, simonwheatley. fixes #13326 for 3.0.1.

#16 @dd32
11 years ago

  • Summary changed from Wodpress does not function on iPad in View (non HTML Mode0 to Wordpress does not function on iPad in View (non HTML Mode0

#17 @nacin
11 years ago

  • Summary changed from Wordpress does not function on iPad in View (non HTML Mode0 to WordPress does not function on iPad in View (non HTML Mode)
Note: See TracTickets for help on using tickets.