Forced SSL Admin has broken preview links

[filosofo]

If you have forced SSL admin, then your cookies are only for https and the preview link, which uses http, is unauthenticated, producing a 404 response.

Patch uses https scheme for the preview link when it's being used in the admin.

[hakre]

+1 and Patch still applies clean!

[ryan]

How about a set_url_scheme() type function?

[nacin]

This doesn't work for custom post types.

?p=123 does not redirect, it 404s. You need ?p=123&post_type=actual_post_type for it to work.

[nacin]

I was going to add post_type=$post_type, but this also won't work if the permalink is filtered in some way.

I think the safest way is a brute force str_replace for now.

[nacin]

filosofo informs me in IRC that ?p=123 not serving/redirecting is a regression.

Going to investigate that. In the meantime, here's one of those patches I don't want to be associated with.

[filosofo]

Actually, this would be a regression: "?p=123 does not redirect, it 404s"

But trunk, using pretty permalinks, redirects a request like that for a draft post to the correct draft url, post_type arg included. So it seems to work (non-SSL).

[ryan]

(In [16903]) Use https for preview links if is_ssl(). Props nacin, filosofo. fixes #13328