Bad UI in Menus: Clicking the + tab's link, when there are no menus, doesn't seem to do anything

[Denis-de-Bernardy]

It directs me to:

​http://localhost/~denis/wp/wp-admin/nav-menus.php?action=edit&menu=0

Entering a menu name doesn't seem to make any difference. Is this link needed or even useful when no menus are present?

[koopersmith]

This is equivalent to clicking on any selected tab's link, though I understand why it may seem slightly more superfluous when there's only one tab to click on (i.e. no menus are present).

The + link itself isn't causing any major problems—the only data lost is the menu name, and you're directed back to the same page. The + tab should not create the menu, as that would be unexpected behavior (and outside of the mental model for a tabbed interface).

That said, we may want to remove links from inside selected tabs (to prevent data loss) or only when the + tab is selected. Marking as ux-feedback.

[jane]

If you are in a menu tab, I would expect the tab state to be active rather than clickable.

[jane]

I said that poorly. I mean that I'd expect it to be in "on state" rather than "clickable take me there" state.

[koopersmith]

It's currently in both states; we should remove the clickable one. I'll write a patch in a day or so if nobody beats me to it.

[nacin]

(In [14667]) Don't link active menu tabs. props koopersmith, fixes #13333.

[nacin]

If you have no menus or are otherwise on the [+] tab, you shouldn't be able to click that one either I don't think.

[koopersmith]

I'm pretty sure I know exactly what's happening here. Will cook up a patch soon.

[koopersmith]

Patch fixes [+] tab bug and a bug where extra spacing appeared between menu items.

[ryan]

(In [14714]) Don't allow clicking the[+] tab when it is active. Props koopersmith. fixes #13333