WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13333 closed defect (bug) (fixed)

Bad UI in Menus: Clicking the + tab's link, when there are no menus, doesn't seem to do anything

Reported by: Denis-de-Bernardy Owned by: koopersmith
Milestone: 3.0 Priority: normal
Severity: minor Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

It directs me to:

http://localhost/~denis/wp/wp-admin/nav-menus.php?action=edit&menu=0

Entering a menu name doesn't seem to make any difference. Is this link needed or even useful when no menus are present?

Attachments (2)

13333.diff (1.3 KB) - added by koopersmith 5 years ago.
13333.2.diff (1.7 KB) - added by koopersmith 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 @koopersmith5 years ago

  • Keywords ux-feedback added; ui ux removed
  • Severity changed from normal to minor

This is equivalent to clicking on any selected tab's link, though I understand why it may seem slightly more superfluous when there's only one tab to click on (i.e. no menus are present).

The + link itself isn't causing any major problems—the only data lost is the menu name, and you're directed back to the same page. The + tab should not create the menu, as that would be unexpected behavior (and outside of the mental model for a tabbed interface).

That said, we may want to remove links from inside selected tabs (to prevent data loss) or only when the + tab is selected. Marking as ux-feedback.

comment:2 @jane5 years ago

If you are in a menu tab, I would expect the tab state to be active rather than clickable.

comment:3 @jane5 years ago

I said that poorly. I mean that I'd expect it to be in "on state" rather than "clickable take me there" state.

comment:4 @koopersmith5 years ago

  • Keywords ux-feedback removed
  • Owner set to koopersmith
  • Status changed from new to accepted

It's currently in both states; we should remove the clickable one. I'll write a patch in a day or so if nobody beats me to it.

@koopersmith5 years ago

comment:5 @koopersmith5 years ago

  • Keywords has-patch added

comment:6 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14667]) Don't link active menu tabs. props koopersmith, fixes #13333.

comment:7 @nacin5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

If you have no menus or are otherwise on the [+] tab, you shouldn't be able to click that one either I don't think.

comment:8 @nacin5 years ago

  • Status changed from reopened to assigned

comment:9 @koopersmith5 years ago

  • Keywords needs-patch added; has-patch removed
  • Status changed from assigned to accepted

I'm pretty sure I know exactly what's happening here. Will cook up a patch soon.

@koopersmith5 years ago

comment:10 @koopersmith5 years ago

  • Keywords has-patch added; needs-patch removed

Patch fixes [+] tab bug and a bug where extra spacing appeared between menu items.

comment:11 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14714]) Don't allow clicking the[+] tab when it is active. Props koopersmith. fixes #13333

Note: See TracTickets for help on using tickets.