WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13338 closed defect (bug) (fixed)

Deleting a menu should land you on the next available menu instead of the + tab

Reported by: Denis-de-Bernardy Owned by: koopersmith
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

In software editors that support tabs (or in browsers, for that matter), killing a tab results in your being navigated to the next available tab (the one to the right, if any, else the one to the left).

WP should not behave any differently when you delete menus.

Attachments (1)

13338.diff (1.4 KB) - added by koopersmith 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @koopersmith5 years ago

  • Keywords ux-feedback added; ui ux removed
  • Severity changed from critical to normal

Agreed. Marking as ux-feedback, but patches welcome.

comment:2 @jane5 years ago

Agreed.

comment:3 @ryan5 years ago

(In [14601]) Go to first tab instead of + after deleting a menu. see #13338

comment:4 @ryan5 years ago

Quick fix to go to the first tab, which is some improvement.

comment:5 @koopersmith5 years ago

I can't remember which ticket this came up in, but do we want the tabs to be rearrangeable? I have an idea for a quick patch if they're not, but it'll break if they are.

comment:6 @koopersmith5 years ago

  • Keywords ux-feedback removed

Given that we're implementing menu slots in #13378, I see no need to implement rearrangeable tabs for 3.0 (since users no longer have to rely on the first menu being the one automatically used by a theme).

comment:7 @koopersmith5 years ago

  • Owner set to koopersmith
  • Status changed from new to accepted

@koopersmith5 years ago

comment:8 @koopersmith5 years ago

  • Keywords has-patch added

Patch selects the next tab (alphabetically, because they're sorted alphabetically). If the deleted menu was the last tab, it selects the last tab (ie the previous tab). If there are no more menus, it selects create menu. It also fixes the bug where no menu tab will be selected if the delete url is refreshed.

comment:9 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14758]) Make the next available tab active after deleting a tab. Props koopersmith. fixes #13338

Note: See TracTickets for help on using tickets.