WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13348 closed defect (bug) (fixed)

IE 7 nav menu admin styling broken

Reported by: ocean90 Owned by: koopersmith
Milestone: 3.0 Priority: high
Severity: blocker Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

There are some issues under IE 7.

Attachments (4)

ie7.patch (8.3 KB) - added by ocean90 5 years ago.
ie7.2.patch (7.3 KB) - added by ocean90 5 years ago.
use IE 7 selector instead of JS detection
ie7.3.patch (2.6 KB) - added by ocean90 5 years ago.
Without unsemantic "clear" divs
ie7.4.patch (2.9 KB) - added by ocean90 5 years ago.
use ie.css for IE 7 hacks

Download all attachments as: .zip

Change History (16)

@ocean905 years ago

comment:1 @ocean905 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

@ocean905 years ago

use IE 7 selector instead of JS detection

comment:2 @ocean905 years ago

  • Keywords has-patch added

comment:3 @filosofo5 years ago

I don't think you should be adding those unsemantic "clear" divs, especially as the clearfix CSS hack has no effect on IE anyways.

comment:4 @nacin5 years ago

  • Severity changed from normal to blocker

comment:5 follow-up: @azaozz5 years ago

Fixes for IE6 & 7 CSS should go to ie.css which is conditionally loaded, no need for css hacks in the main stylesheet.

comment:6 in reply to: ↑ 5 @ocean905 years ago

Replying to azaozz:

Fixes for IE6 & 7 CSS should go to ie.css which is conditionally loaded, no need for css hacks in the main stylesheet.

For IE 6 yes, but not for IE 7. <!--[if lte IE 7]> is only for IE 6.

@ocean905 years ago

Without unsemantic "clear" divs

comment:7 @ocean905 years ago

I added a new patch without unsemantic "clear" divs. Only CSS and one fix in nav-menu.php.

comment:8 @nacin5 years ago

  • Cc has-patch removed
  • Keywords needs-patch added; has-patch removed

"lte IE7" means less than or equal. ie.css gets served for both 6 and 7.

I would want koopersmith, maybe filosofo to review anything going into the main stylesheet to ensure we're not breaking anything else.

@ocean905 years ago

use ie.css for IE 7 hacks

comment:9 @ocean905 years ago

  • Keywords has-patch added; needs-patch removed

nacin, oops! :)

comment:10 @nacin5 years ago

  • Owner changed from ocean90 to koopersmith
  • Status changed from accepted to assigned

comment:11 @filosofo5 years ago

With my patch on #13388, IE 7 seems pretty good too.

comment:12 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14761]) Menu styling fixes for IE. Props filosofo, ocean90. fixes #13388 #13348

Note: See TracTickets for help on using tickets.