Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 16 years ago

Closed 16 years ago

#13348 closed defect (bug) (fixed)

IE 7 nav menu admin styling broken

Reported by:	ocean90	Owned by:	koopersmith
Priority:	high	Milestone:	3.0
Component:	Menus	Version:	3.0
Severity:	blocker	Keywords:	has-patch
Cc:		Focuses:

Description

There are some issues under IE 7.

Attachments (4)

ie7.patch (8.3 KB ) - added by ocean90 16 years ago.
ie7.2.patch (7.3 KB ) - added by ocean90 16 years ago.: use IE 7 selector instead of JS detection
ie7.3.patch (2.6 KB ) - added by ocean90 16 years ago.: Without unsemantic "clear" divs
ie7.4.patch (2.9 KB ) - added by ocean90 16 years ago.: use ie.css for IE 7 hacks

Download all attachments as: .zip

Change History (16)

@ocean90
16 years ago

Attachment ie7.patch added

#1 @ocean90
16 years ago

Owner set to ocean90
Status new → accepted

@ocean90
16 years ago

Attachment ie7.2.patch added

use IE 7 selector instead of JS detection

#2 @ocean90
16 years ago

Keywords has-patch added

#3 @filosofo
16 years ago

I don't think you should be adding those unsemantic "clear" divs, especially as the clearfix CSS hack has no effect on IE anyways.

#4 @nacin
16 years ago

Severity normal → blocker

#5 follow-up: ↓ 6 @azaozz
16 years ago

Fixes for IE6 & 7 CSS should go to ie.css which is conditionally loaded, no need for css hacks in the main stylesheet.

#6 in reply to: ↑ 5 @ocean90
16 years ago

Replying to azaozz:

Fixes for IE6 & 7 CSS should go to ie.css which is conditionally loaded, no need for css hacks in the main stylesheet.

For IE 6 yes, but not for IE 7. <!--[if lte IE 7]> is only for IE 6.

@ocean90
16 years ago

Attachment ie7.3.patch added

Without unsemantic "clear" divs

#7 @ocean90
16 years ago

I added a new patch without unsemantic "clear" divs. Only CSS and one fix in nav-menu.php.

#8 @nacin
16 years ago

Cc has-patch removed
Keywords needs-patch added; has-patch removed

"lte IE7" means less than or equal. ie.css gets served for both 6 and 7.

I would want koopersmith, maybe filosofo to review anything going into the main stylesheet to ensure we're not breaking anything else.

@ocean90
16 years ago

Attachment ie7.4.patch added

use ie.css for IE 7 hacks

#9 @ocean90
16 years ago

Keywords has-patch added; needs-patch removed

nacin, oops! :)

#10 @nacin
16 years ago

Owner changed from ocean90 to koopersmith
Status accepted → assigned

#11 @filosofo
16 years ago

With my patch on #13388, IE 7 seems pretty good too.

#12 @ryan
16 years ago

Resolution → fixed
Status assigned → closed

(In [14761]) Menu styling fixes for IE. Props filosofo, ocean90. fixes #13388 #13348

Note: See TracTickets for help on using tickets.

Download in other formats: