WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #13361


Ignore:
Timestamp:
05/11/10 21:31:27 (4 years ago)
Author:
nacin
Comment:

Editing the title and description, and assigning to Matt Thomas.

This was brought up on one of the mailing lists a month ago as well. More or less, as the new description indicates, the excerpt_more text isn't used when we're handling custom excerpts. That might have been an oversight in 2.9, but that's too late to address in 3.0.

That said, perhaps Twenty Ten should filter excerpt_more to an empty string, then always append 'Continue Reading' on our own.

Also, there's some bad code there. the_excerpt does not take any parameters. No matter how hard you try, it won't echo out a link the way the_content does.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13361

    • Property Owner set to iammattthomas
    • Property Status changed from new to assigned
    • Property Component changed from Template to Themes
    • Property Summary changed from the_excerpt() not return Continuation text when return excerpt for a post to In Twenty Ten, custom excerpts do not show "Continue reading"
  • Ticket #13361 – Description

    initial v1  
    1 I am trying to get the_excerpt() to work on 3.0 beta 2 with 2010  
    2  
    3 we have this  code 
    4 <?php if ( is_archive() || is_search() ) : // Only display Excerpts for archives & search ?> 
    5                         <div class="entry-summary"> 
    6                                 <?php the_excerpt( __( 'Continue reading <span class="meta-nav">&rarr;</span>', 'twentyten' ) ); ?> 
    7                         </div><!-- .entry-summary --> 
    8         <?php else : ?> 
    9 also 
    10 /** 
    11  * Sets the "read more" link to something pretty. 
    12  * 
    13  * To override this link in a child theme, remove the filter and add your own 
    14  * function tied to the excerpt_more filter hook. 
    15  * 
    16  * @since 3.0.0 
    17  * @return string A pretty 'Continue reading' link. 
    18  */ 
    19 function twentyten_excerpt_more( $more ) { 
    20         return ' &hellip; <a href="'. get_permalink() . '">' . __('Continue reading <span class="meta-nav">&rarr;</span>', 'twentyten') . '</a>'; 
    21 } 
    22 add_filter( 'excerpt_more', 'twentyten_excerpt_more' ); 
    23  
    24 in function.php 
    25  
    26 But I am not getting  the "Continue reading " text and link if I enter an extract into the post only for the more tag ect. 
     1The excerpt_more text is only used when an excerpt needs to be cut down in length in wp_trim_excerpt. A custom excerpt will not get a "Continue reading" link in Twenty Ten.